Only run the provided delayed operation early

Author: schmidt-sebastian

packages/firestore/CHANGELOG.md

@@ -1,4 +1,6 @@
 # Unreleased
+- [fixed] Fixed an issue that could cause Firestore to temporarily go 
+  offline when a Window visibility event occurred.
 - [feature] Added support for calling  `FirebaseFiresore.settings` with 
   `{ ignoreUndefinedProperties: true }`. When set, Firestore ignores 
   undefined properties inside objects rather than rejecting the API call.

packages/firestore/src/local/index_free_query_engine.ts

@@ -196,7 +196,7 @@ export class IndexFreeQueryEngine implements QueryEngine {
     if (getLogLevel() <= LogLevel.DEBUG) {
       logDebug(
         'IndexFreeQueryEngine',
-        'Using full collection scan to execute query: %s',
+        'Using full collection scan to execute query:',
         query.toString()
       );
     }

packages/firestore/src/util/async_queue.ts

@@ -463,23 +463,21 @@ export class AsyncQueue {
   }
 
   /**
-   * For Tests: Runs some or all delayed operations early.
+   * Runs some or all delayed operations early.
    *
-   * @param lastTimerId Delayed operations up to and including this TimerId will
-   *  be drained. Throws if no such operation exists. Pass TimerId.All to run
-   *  all delayed operations.
+   * @param timerId Delayed operations to run. Pass TimerId.All to run all
+   * delayed operations.
    * @returns a Promise that resolves once all operations have been run.
    */
-  runDelayedOperationsEarly(lastTimerId: TimerId): Promise<void> {
+  runDelayedOperationsEarly(timerId: TimerId): Promise<void> {
     // Note that draining may generate more delayed ops, so we do that first.
     return this.drain().then(() => {
       // Run ops in the same order they'd run if they ran naturally.
       this.delayedOperations.sort((a, b) => a.targetTimeMs - b.targetTimeMs);
 
       for (const op of this.delayedOperations) {
-        op.skipDelay();
-        if (lastTimerId !== TimerId.All && op.timerId === lastTimerId) {
-          break;
+        if (timerId === TimerId.All || op.timerId === timerId) {
+          op.skipDelay();
         }
       }
 

packages/firestore/test/unit/util/async_queue.test.ts

@@ -20,7 +20,7 @@ import * as chaiAsPromised from 'chai-as-promised';
 import { expect, use } from 'chai';
 import { AsyncQueue, TimerId } from '../../../src/util/async_queue';
 import { Code } from '../../../src/util/error';
-import { getLogLevel, setLogLevel, LogLevel } from '../../../src/util/log';
+import { getLogLevel, LogLevel, setLogLevel } from '../../../src/util/log';
 import { Deferred, Rejecter, Resolver } from '../../../src/util/promise';
 import { fail } from '../../../src/util/assert';
 import { IndexedDbTransactionError } from '../../../src/local/simple_db';
@@ -206,7 +206,13 @@ describe('AsyncQueue', () => {
     queue.enqueueAndForget(() => doStep(2));
 
     await queue.runDelayedOperationsEarly(timerId3);
-    expect(completedSteps).to.deep.equal([1, 2, 3, 4]);
+    expect(completedSteps).to.deep.equal([1, 2, 4]);
+
+    await queue.runDelayedOperationsEarly(timerId2);
+    expect(completedSteps).to.deep.equal([1, 2, 4, 3]);
+
+    await queue.runDelayedOperationsEarly(timerId1);
+    expect(completedSteps).to.deep.equal([1, 2, 4, 3, 5]);
   });
 
   it('Retries retryable operations', async () => {