Fix broken node tests

Author: sam-gc

packages-exp/auth-compat-exp/index.node.ts

@@ -24,6 +24,7 @@
 export * from './index';
 import { FetchProvider } from '@firebase/auth-exp/internal';
 import * as fetchImpl from 'node-fetch';
+import './index';
 
 FetchProvider.initialize(
   (fetchImpl.default as unknown) as typeof fetch,

packages-exp/auth-compat-exp/index.ts

@@ -136,7 +136,7 @@ function registerAuthCompat(instance: _FirebaseNamespace): void {
       .setMultipleInstances(false)
   );
 
-  instance.registerVersion('auth', version);
+  instance.registerVersion('auth-compat', version);
 }
 
 registerAuthCompat(firebase as _FirebaseNamespace);

packages-exp/auth-compat-exp/rollup.config.shared.js

@@ -65,7 +65,7 @@ export function getEs5Builds(additionalTypescriptPlugins = {}) {
       plugins: es5BuildPlugins,
       external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)),
       treeshake: {
-        moduleSideEffects: false
+        moduleSideEffects: true
       }
     },
     /**

packages-exp/auth-compat-exp/src/auth.ts

@@ -61,17 +61,22 @@ export class Auth
       appName: app.name
     });
 
-    // Note this is slightly different behavior: in this case, the stored
-    // persistence is checked *first* rather than last. This is because we want
-    // to prefer stored persistence type in the hierarchy.
-    const persistences = _getPersistencesFromRedirect(apiKey, app.name);
+    let persistences: exp.Persistence[] = [exp.inMemoryPersistence];
 
-    for (const persistence of [
-      exp.indexedDBLocalPersistence,
-      exp.browserLocalPersistence
-    ]) {
-      if (!persistences.includes(persistence)) {
-        persistences.push(persistence);
+    // Only deal with persistences in web environments
+    if (typeof window !== 'undefined') {
+      // Note this is slightly different behavior: in this case, the stored
+      // persistence is checked *first* rather than last. This is because we want
+      // to prefer stored persistence type in the hierarchy.
+      persistences = _getPersistencesFromRedirect(apiKey, app.name);
+
+      for (const persistence of [
+        exp.indexedDBLocalPersistence,
+        exp.browserLocalPersistence
+      ]) {
+        if (!persistences.includes(persistence)) {
+          persistences.push(persistence);
+        }
       }
     }