Skip to content

Commit d073329

Browse files
schmidt-sebastianschmidt-sebastian
committed
Merge
2 parents bfb11a5 + 487f8e1 commit d073329

File tree

858 files changed

+23280
-26537
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

858 files changed

+23280
-26537
lines changed

‎.changeset/calm-shrimps-press.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎.changeset/config.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
{
22
"$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
3-
"changelog": ["../repo-scripts/changelog-generator", { "repo": "firebase/firebase-js-sdk"}],
3+
"changelog": [
4+
"../repo-scripts/changelog-generator",
5+
{ "repo": "firebase/firebase-js-sdk" }
6+
],
47
"commit": false,
58
"linked": [],
69
"access": "public",
@@ -20,6 +23,9 @@
2023
"@firebase/functions-types-exp",
2124
"@firebase/installations-exp",
2225
"@firebase/installations-types-exp",
26+
"@firebase/installations-compat",
27+
"@firebase/messaging-exp",
28+
"@firebase/messaging-types-exp",
2329
"@firebase/performance-exp",
2430
"@firebase/performance-types-exp",
2531
"@firebase/remote-config-exp",

‎.changeset/dirty-hotels-cheat.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@firebase/database': patch
3+
---
4+
5+
Fix issue with multiple database instances when using Realtime Database emulator (#3681)

‎.changeset/early-dots-peel.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎.changeset/slimy-mugs-type.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@firebase/firestore": patch
3+
---
4+
5+
Fixes an issue in the Transaction API that caused the SDK to return invalid DocumentReferences through `DocumentSnapshot.data()` calls.

‎.github/CODEOWNERS

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ packages/messaging-types @zwu52 @firebase/jssdk-global-approvers
5555
integration/messaging @zwu52 @firebase/jssdk-global-approvers
5656

5757
# Auth Code
58-
packages/auth @bojeil-google @avolkovi @samhorlbeck @firebase/jssdk-global-approvers
59-
packages/auth-types @bojeil-google @avolkovi @samhorlbeck @firebase/jssdk-global-approvers
58+
packages/auth @bojeil-google @avolkovi @samhorlbeck @yuchenshi @firebase/jssdk-global-approvers
59+
packages/auth-types @bojeil-google @avolkovi @samhorlbeck @yuchenshi @firebase/jssdk-global-approvers
6060

6161
# Testing Code
6262
packages/testing @avolkovi @samhorlbeck @yuchenshi @firebase/jssdk-global-approvers
@@ -89,9 +89,9 @@ scripts/docgen/content-sources/ @firebase/firebase-techwriters @firebase/jssdk-g
8989
.changeset @firebase/firebase-techwriters @firebase/jssdk-changeset-approvers @firebase/firestore-js-team @firebase/jssdk-global-approvers
9090

9191
# Auth-Exp Code
92-
packages-exp/auth-exp @avolkovi @samhorlbeck @firebase/jssdk-global-approvers
93-
packages-exp/auth-types-exp @avolkovi @samhorlbeck @firebase/jssdk-global-approvers
94-
packages-exp/auth-compat-exp @avolkovi @samhorlbeck @firebase/jssdk-global-approvers
92+
packages-exp/auth-exp @avolkovi @samhorlbeck @yuchenshi @firebase/jssdk-global-approvers
93+
packages-exp/auth-types-exp @avolkovi @samhorlbeck @yuchenshi @firebase/jssdk-global-approvers
94+
packages-exp/auth-compat-exp @avolkovi @samhorlbeck @yuchenshi @firebase/jssdk-global-approvers
9595

9696
# Installations-Exp Code
9797
packages/installations-exp @andirayo @ChaoqunCHEN @firebase/jssdk-global-approvers

‎.github/ISSUE_TEMPLATE/alpha_bug_report.md

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
---
2+
name: 🧪 Alpha SDK bug report
3+
about: Have you found a bug in one of our pre-release or alpha SDKs? File it here.
4+
title: ''
5+
labels: alpha
6+
assignees: ''
7+
8+
---
9+
10+
<!-- Step 1 [READ THIS] -->
11+
<!--
12+
Are you in the right place?
13+
* For issues or feature requests related to __the code in this repository__
14+
file a Github issue.
15+
* If you are not yet participating in our Alpha and would like to join, use this form:
16+
https://forms.gle/bKBEm48W8EMPLaUp9
17+
* For general Alpha discussion, use the google group:
18+
https://groups.google.com/g/firebase-js-sdk-testers
19+
-->
20+
21+
<!-- Step 2 -->
22+
23+
### [REQUIRED] Describe your environment
24+
25+
* Operating System version: _____
26+
* Browser version: _____
27+
* Firebase SDK version: _____
28+
* Firebase Product: _____ (auth, database, storage, etc)
29+
30+
<!-- Step 3 -->
31+
32+
### [REQUIRED] Describe the problem
33+
34+
#### Steps to reproduce:
35+
<!--
36+
What happened? How can we make the problem occur?
37+
This could be a description, log/console output, etc.
38+
-->
39+
#### Relevant Code:
40+
41+
```javascript
42+
// TODO(you): code here to reproduce the problem
43+
```

‎.github/ISSUE_TEMPLATE.md renamed to ‎.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,18 @@
1+
---
2+
name: 🐞 Bug report
3+
about: Found a bug in the JS SDK? File it here.
4+
title: ''
5+
labels: ''
6+
assignees: ''
7+
8+
---
9+
10+
111
<!-- Step 1 [READ THIS] -->
212
<!--
13+
14+
**Thank you for submitting your issue. We are operating at reduced capacity from Dec 18 2020 to Jan 4 2021. Please expect delayed responses. For more urgent requests please reach us via our support channels https://firebase.google.com/support**
15+
316
Are you in the right place?
417
* For issues or feature requests related to __the code in this repository__
518
file a Github issue.
@@ -11,6 +24,7 @@ Are you in the right place?
1124
* For help troubleshooting your application that does not fall under one
1225
of the above categories, reach out to the personalized
1326
[Firebase support channel](https://firebase.google.com/support/).
27+
1428
-->
1529

1630
<!-- Step 2 -->
@@ -33,12 +47,6 @@ Are you in the right place?
3347
-->
3448
#### Relevant Code:
3549

36-
<!--
37-
Reproduce the issue on StackBlitz and provide your forked URL
38-
or give us some sample code below
39-
-->
40-
https://stackblitz.com/fork/firebase-issue-sandbox
41-
4250
```javascript
4351
// TODO(you): code here to reproduce the problem
4452
```

‎.github/ISSUE_TEMPLATE/config.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
blank_issues_enabled: false
2+
contact_links:
3+
- name: 🔥 Firebase Support
4+
url: https://firebase.google.com/support/
5+
about: If you have an urgent issue with your app in production, please contact support.

‎.github/workflows/canary-deploy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
# Canary release script requires git history and tags.
1818
fetch-depth: 0
1919
- name: Set up Node (10)
20-
uses: actions/setup-node@v1
20+
uses: actions/setup-node@v2
2121
with:
2222
node-version: 10.x
2323
- name: Yarn install

‎.github/workflows/check-changeset.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
# This makes Actions fetch all Git history so check_changeset script can diff properly.
1515
fetch-depth: 0
1616
- name: Set up Node (10)
17-
uses: actions/setup-node@v1
17+
uses: actions/setup-node@v2
1818
with:
1919
node-version: 10.x
2020
- name: Yarn install

‎.github/workflows/cross-browser-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
steps:
1717
- uses: actions/checkout@v2
1818
- name: Use Node.js 10.x
19-
uses: actions/setup-node@v1
19+
uses: actions/setup-node@v2
2020
with:
2121
node-version: 10.x
2222
- name: Test setup and yarn install

‎.github/workflows/health-metrics-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
runs-on: ubuntu-latest
1515
steps:
1616
- uses: actions/checkout@v2
17-
- uses: actions/setup-node@v1
17+
- uses: actions/setup-node@v2
1818
with:
1919
node-version: 10.x
2020
- uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
@@ -30,7 +30,7 @@ jobs:
3030
runs-on: ubuntu-latest
3131
steps:
3232
- uses: actions/checkout@v2
33-
- uses: actions/setup-node@v1
33+
- uses: actions/setup-node@v2
3434
with:
3535
node-version: 10.x
3636
- uses: GoogleCloudPlatform/github-actions/setup-gcloud@master

‎.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
steps:
1111
- uses: actions/checkout@v2
1212
- name: Set up Node (10)
13-
uses: actions/setup-node@v1
13+
uses: actions/setup-node@v2
1414
with:
1515
node-version: 10.x
1616
- name: yarn install

‎.github/workflows/prerelease-manual-deploy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
# Canary release script requires git history and tags.
2222
fetch-depth: 0
2323
- name: Set up Node (10)
24-
uses: actions/setup-node@v1
24+
uses: actions/setup-node@v2
2525
with:
2626
node-version: 10.x
2727
- name: Yarn install

‎.github/workflows/test-all.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
steps:
1111
- uses: actions/checkout@v2
1212
- name: Set up Node (10)
13-
uses: actions/setup-node@v1
13+
uses: actions/setup-node@v2
1414
with:
1515
node-version: 10.x
1616
- name: install Chrome stable
@@ -26,7 +26,7 @@ jobs:
2626
- name: yarn build
2727
run: yarn build
2828
- name: Set start timestamp env var
29-
run: echo "::set-env name=FIREBASE_CI_TEST_START_TIME::$(date +%s)"
29+
run: echo "FIREBASE_CI_TEST_START_TIME=$(date +%s)" >> $GITHUB_ENV
3030
- name: Run unit tests
3131
run: |
3232
xvfb-run yarn test:ci

‎.github/workflows/test-changed-auth.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
# This makes Actions fetch all Git history so run-changed script can diff properly.
1515
fetch-depth: 0
1616
- name: Set up Node (10)
17-
uses: actions/setup-node@v1
17+
uses: actions/setup-node@v2
1818
with:
1919
node-version: 10.x
2020
- name: install Chrome stable

‎.github/workflows/test-changed-fcm-integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
# This makes Actions fetch all Git history so run-changed script can diff properly.
1515
fetch-depth: 0
1616
- name: Set up Node (10)
17-
uses: actions/setup-node@v1
17+
uses: actions/setup-node@v2
1818
with:
1919
node-version: 10.x
2020
- name: install Chrome stable

‎.github/workflows/test-changed-firestore-integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
# This makes Actions fetch all Git history so run-changed script can diff properly.
1515
fetch-depth: 0
1616
- name: Set up Node (10)
17-
uses: actions/setup-node@v1
17+
uses: actions/setup-node@v2
1818
with:
1919
node-version: 10.x
2020
- name: install Chrome stable

‎.github/workflows/test-changed-firestore.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
# This makes Actions fetch all Git history so run-changed script can diff properly.
1515
fetch-depth: 0
1616
- name: Set up Node (10)
17-
uses: actions/setup-node@v1
17+
uses: actions/setup-node@v2
1818
with:
1919
node-version: 10.x
2020
- name: install Chrome stable

‎.github/workflows/test-changed-misc.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
# This makes Actions fetch all Git history so run-changed script can diff properly.
1515
fetch-depth: 0
1616
- name: Set up Node (10)
17-
uses: actions/setup-node@v1
17+
uses: actions/setup-node@v2
1818
with:
1919
node-version: 10.x
2020
- name: install Chrome stable

‎.github/workflows/test-changed.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
# This makes Actions fetch all Git history so run-changed script can diff properly.
1515
fetch-depth: 0
1616
- name: Set up Node (10)
17-
uses: actions/setup-node@v1
17+
uses: actions/setup-node@v2
1818
with:
1919
node-version: 10.x
2020
- name: install Chrome stable

‎.github/workflows/test-firebase-integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
# This makes Actions fetch all Git history so run-changed script can diff properly.
1515
fetch-depth: 0
1616
- name: Set up Node (10)
17-
uses: actions/setup-node@v1
17+
uses: actions/setup-node@v2
1818
with:
1919
node-version: 10.x
2020
- name: install Chrome stable

‎.vscode/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@
1111
},
1212
"typescript.tsdk": "node_modules/typescript/lib",
1313
"files.associations": { "*.json": "jsonc" }
14-
}
14+
}

‎common/api-review/auth-exp.api.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export class ActionCodeURL implements externs.ActionCodeURL {
2929
// (undocumented)
3030
readonly languageCode: string | null;
3131
// (undocumented)
32-
readonly operation: externs.Operation;
32+
readonly operation: externs.ActionCodeOperation;
3333
// (undocumented)
3434
static parseLink(link: string): externs.ActionCodeURL | null;
3535
// (undocumented)
@@ -146,7 +146,7 @@ export function fetchSignInMethodsForEmail(auth: externs.Auth, email: string): P
146146
export function getAdditionalUserInfo(userCredential: externs.UserCredential): externs.AdditionalUserInfo | null;
147147

148148
// @public
149-
export function getAuth(app?: FirebaseApp): Auth;
149+
export function getAuth(app: FirebaseApp): Auth;
150150

151151
// @public
152152
export function getIdToken(user: externs.User, forceRefresh?: boolean): Promise<string>;
@@ -186,7 +186,7 @@ export const indexedDBLocalPersistence: externs.Persistence;
186186
// Warning: (ae-forgotten-export) The symbol "Dependencies" needs to be exported by the entry point index.d.ts
187187
//
188188
// @public (undocumented)
189-
export function initializeAuth(app?: FirebaseApp, deps?: Dependencies): externs.Auth;
189+
export function initializeAuth(app: FirebaseApp, deps?: Dependencies): externs.Auth;
190190

191191
// @public
192192
export const inMemoryPersistence: externs.Persistence;
@@ -247,8 +247,10 @@ export class OAuthProvider implements externs.AuthProvider {
247247
constructor(providerId: string);
248248
addScope(scope: string): externs.AuthProvider;
249249
credential(params: OAuthCredentialOptions): externs.OAuthCredential;
250+
static credentialFromError(error: FirebaseError): externs.OAuthCredential | null;
250251
// (undocumented)
251252
static credentialFromJSON(json: object | string): externs.OAuthCredential;
253+
static credentialFromResult(userCredential: externs.UserCredential): externs.OAuthCredential | null;
252254
// @internal (undocumented)
253255
defaultLanguageCode: string | null;
254256
getCustomParameters(): CustomParameters;
@@ -363,7 +365,7 @@ export function sendPasswordResetEmail(auth: externs.Auth, email: string, action
363365
export function sendSignInLinkToEmail(auth: externs.Auth, email: string, actionCodeSettings?: externs.ActionCodeSettings): Promise<void>;
364366

365367
// @public
366-
export function setPersistence(auth: externs.Auth, persistence: externs.Persistence): void;
368+
export function setPersistence(auth: externs.Auth, persistence: externs.Persistence): Promise<void>;
367369

368370
// @public
369371
export function signInAnonymously(auth: externs.Auth): Promise<externs.UserCredential>;

‎common/api-review/auth-types-exp.api.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,9 @@ export interface AuthError extends FirebaseError {
105105
readonly tenantid?: string;
106106
}
107107

108+
// @public
109+
export interface AuthErrorMap {}
110+
108111
// @public
109112
export interface AuthProvider {
110113
readonly providerId: string;

‎common/api-review/firestore-exp.api.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import { _FirebaseService } from '@firebase/app-types-exp';
1111
import { LogLevelString as LogLevel } from '@firebase/logger';
1212
import { Provider } from '@firebase/component';
1313
import { SetOptions as SetOptions_2 } from '@firebase/firestore-types';
14-
import { SnapshotMetadata as SnapshotMetadata_2 } from '@firebase/firestore-types';
1514

1615
// @public
1716
export function addDoc<T>(reference: CollectionReference<T>, data: T): Promise<DocumentReference<T>>;
@@ -440,11 +439,11 @@ export interface SnapshotListenOptions {
440439
}
441440

442441
// @public
443-
export class SnapshotMetadata implements SnapshotMetadata_2 {
442+
export class SnapshotMetadata {
444443
constructor(hasPendingWrites: boolean, fromCache: boolean);
445444
readonly fromCache: boolean;
446445
readonly hasPendingWrites: boolean;
447-
isEqual(other: SnapshotMetadata_2): boolean;
446+
isEqual(other: SnapshotMetadata): boolean;
448447
}
449448

450449
// @public

0 commit comments

Comments
 (0)