Skip to content

Commit d18be98

Browse files
committed
Merge remote-tracking branch 'origin/master' into mila/fix-cache-empty-result-bug
2 parents 0ae4afc + a491888 commit d18be98

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

packages/firebase/compat/index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4003,8 +4003,8 @@ declare namespace firebase.auth {
40034003
/**
40044004
* @example
40054005
* ```javascript
4006-
* var cred = firebase.auth.FacebookAuthProvider.credential(
4007-
* // `event` from the Facebook auth.authResponseChange callback.
4006+
* var cred = firebase.auth.GithubAuthProvider.credential(
4007+
* // `event` from the GithubAuthProvider auth.authResponseChange callback.
40084008
* event.authResponse.accessToken
40094009
* );
40104010
* ```

scripts/emulator-testing/emulators/database-emulator.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ export class DatabaseEmulator extends Emulator {
2626

2727
constructor(port = 8088, namespace = 'test-emulator') {
2828
super(
29-
'firebase-database-emulator-v4.4.1.jar',
29+
'firebase-database-emulator-v4.9.0.jar',
3030
// Use locked version of emulator for test to be deterministic.
3131
// The latest version can be found from database emulator doc:
3232
// https://firebase.google.com/docs/database/security/test-rules-emulator
33-
'https://storage.googleapis.com/firebase-preview-drop/emulator/firebase-database-emulator-v4.6.0.jar',
33+
'https://storage.googleapis.com/firebase-preview-drop/emulator/firebase-database-emulator-v4.9.0.jar',
3434
port
3535
);
3636
this.namespace = namespace;

0 commit comments

Comments
 (0)