Add one more test case

Author: schmidt-sebastian

packages/firestore/src/util/log.ts

@@ -59,10 +59,10 @@ export function setLogLevel(newLevel: LogLevel): void {
 }
 
 export function debug(tag: string, msg: string, ...obj: unknown[]): void {
-  if (logClient.logLevel <= FirebaseLogLevel.DEBUG) {
-    const args = obj.map(argToString);
-    logClient.debug(`Firestore (${SDK_VERSION}) [${tag}]: ${msg}`, ...args);
-  }
+  //  if (logClient.logLevel <= FirebaseLogLevel.DEBUG) {
+  const args = obj.map(argToString);
+  console.info(`Firestore (${SDK_VERSION}) [${tag}]: ${msg}`, ...args);
+  // }
 }
 
 export function error(msg: string, ...obj: unknown[]): void {

packages/firestore/test/unit/specs/limit_spec.test.ts

@@ -218,12 +218,12 @@ describeSpec('Limits:', [], () => {
   );
 
   specTest(
-    'Initial snapshots for limit queries are re-filled from cache (with order change)',
+    'Initial snapshots for limit queries are re-filled from cache (with uncommitted change)',
     [],
     () => {
       // Verify that views for limit queries contain the correct set of documents
-      // even if a previously matching document is updated to sort below an older
-      // document.
+      // even if a previously matching document receives a latency-compensate update
+      // that makes it sort below an older document.
       const fullQuery = Query.atPath(path('collection'));
       const limitQuery = Query.atPath(path('collection'))
         .addOrderBy(orderBy('pos'))
@@ -237,6 +237,7 @@ describeSpec('Limits:', [], () => {
         .watchAcksFull(fullQuery, 1003, doc1, doc2, doc3)
         .expectEvents(fullQuery, { added: [doc1, doc2, doc3] })
         .userUnlistens(fullQuery)
+        .watchRemoves(fullQuery)
         .userListens(limitQuery)
         .expectEvents(limitQuery, { added: [doc1, doc2], fromCache: true })
         .watchAcksFull(limitQuery, 1004, doc1, doc2)
@@ -249,6 +250,43 @@ describeSpec('Limits:', [], () => {
     }
   );
 
+  specTest(
+    'Initial snapshots for limit queries are re-filled from cache (with committed change)',
+    [],
+    () => {
+      // Verify that views for limit queries contain the correct set of documents
+      // even if a previously matching document receives an update from the backend
+      // that makes it sort below an older document.
+      const fullQuery = Query.atPath(path('collection'));
+      const limitQuery = Query.atPath(path('collection'))
+        .addOrderBy(orderBy('pos'))
+        .withLimit(2);
+      const doc1 = doc('collection/a', 1001, { pos: 1 });
+      const doc1Edited = doc('collection/a', 1005, { pos: 4 });
+      const doc2 = doc('collection/b', 1002, { pos: 2 });
+      const doc3 = doc('collection/c', 1003, { pos: 3 });
+      return spec()
+        .withGCEnabled(false)
+        .userListens(fullQuery)
+        .watchAcksFull(fullQuery, 1003, doc1, doc2, doc3)
+        .expectEvents(fullQuery, { added: [doc1, doc2, doc3] })
+        .userUnlistens(fullQuery)
+        .watchRemoves(fullQuery)
+        .userListens(limitQuery)
+        .expectEvents(limitQuery, { added: [doc1, doc2], fromCache: true })
+        .watchAcksFull(limitQuery, 1004, doc1, doc2)
+        .expectEvents(limitQuery, {})
+        .userUnlistens(limitQuery)
+        .watchRemoves(limitQuery)
+        .userListens(fullQuery, 'resume-token-1003')
+        .expectEvents(fullQuery, { added: [doc1, doc2, doc3], fromCache: true })
+        .watchAcksFull(fullQuery, 1005, doc1Edited)
+        .expectEvents(fullQuery, { modified: [doc1Edited] })
+        .userListens(limitQuery, 'resume-token-1004')
+        .expectEvents(limitQuery, { added: [doc2, doc3], fromCache: true });
+    }
+  );
+
   specTest(
     'Resumed limit queries exclude deleted documents ',
     ['durable-persistence'],