address comments

Author: Feiyang1

packages/app/next/package.json

@@ -4,5 +4,5 @@
     "browser": "../dist/cjs/next.js",
     "module": "../dist/esm5/next.js",
     "esm2017": "../dist/esm2017/next.js",
-    "typings": "../ådist/packages/app/src/next/index.d.ts"
+    "typings": "../dist/packages/app/src/next/index.d.ts"
 }

packages/app/rollup.config.js

@@ -131,4 +131,3 @@ const es2017Builds = [
 ];
 
 export default [...es5Builds, ...es2017Builds];
-// export default [...es2017Builds];

packages/app/src/compat/firebaseApp.ts

@@ -60,8 +60,13 @@ export class FirebaseAppImpl implements FirebaseApp {
   }
 
   delete(): Promise<void> {
-    this.firebase.INTERNAL.removeApp(this.name);
-    return deleteApp(this.app);
+    return new Promise(resolve => {
+      this.app.checkDestroyed();
+      resolve();
+    }).then(() => {
+      this.firebase.INTERNAL.removeApp(this.name);
+      return deleteApp(this.app);
+    });
   }
 
   /**

packages/app/test/firebaseApp.test.ts renamed to packages/app/test/firebaseCompat.test.ts

@@ -229,7 +229,7 @@ function firebaseAppTests(
       return Promise.all(deleteTasks);
     });
 
-    it(' has no initial apps.', () => {
+    it('has no initial apps.', () => {
       expect(firebase.apps.length).to.eq(0);
     });
 

packages/app/test/util.ts

@@ -22,8 +22,6 @@ import { ComponentType, Component } from '@firebase/component';
 export class TestService implements FirebaseService {
   constructor(private app_: FirebaseApp, public instanceIdentifier?: string) {}
 
-  // TODO(koss): Shouldn't this just be an added method on
-  // the service instance?
   get app(): FirebaseApp {
     return this.app_;
   }