addressed PR comments

Author: XuechunHou

scripts/size_report/report_binary_size.ts

@@ -19,7 +19,12 @@ import { resolve } from 'path';
 import * as fs from 'fs';
 import { execSync } from 'child_process';
 import * as terser from 'terser';
-import { upload, runId, RequestBody } from './size_report_helper';
+import {
+  upload,
+  runId,
+  RequestBody,
+  RequestEndpoint
+} from './size_report_helper';
 
 interface Report {
   sdk: string;
@@ -136,9 +141,9 @@ function traverseDirs(
 
 function makeReportObject(sdk: string, type: string, value: number): Report {
   return {
-    sdk: sdk,
-    type: type,
-    value: value
+    sdk,
+    type,
+    value
   };
 }
 
@@ -164,4 +169,4 @@ function generateSizeReport(): BinarySizeRequestBody {
 }
 
 const report = generateSizeReport();
-upload(report, 'reports');
+upload(report, RequestEndpoint.BINARY_SIZE);

scripts/size_report/report_modular_export_binary_size.ts

@@ -21,17 +21,17 @@ import {
 } from '../../repo-scripts/size-analysis/analysis-helper';
 import { mapWorkspaceToPackages } from '../release/utils/workspace';
 import { projectRoot } from '../utils';
-import { upload, runId, RequestBody } from './size_report_helper';
+import {
+  upload,
+  runId,
+  RequestBody,
+  RequestEndpoint
+} from './size_report_helper';
 interface ModularExportBinarySizeRequestBody extends RequestBody {
   modules: Report[];
 }
 
 async function generateReport(): Promise<ModularExportBinarySizeRequestBody> {
-  const requestBody: ModularExportBinarySizeRequestBody = {
-    log: `https://github.com/${process.env.GITHUB_REPOSITORY}/actions/runs/${runId}`,
-    modules: []
-  };
-
   let allModulesLocation: string[] = await mapWorkspaceToPackages([
     `${projectRoot}/packages-exp/*`
   ]);
@@ -46,17 +46,15 @@ async function generateReport(): Promise<ModularExportBinarySizeRequestBody> {
   });
 
   const reports: Report[] = await generateReportForModules(allModulesLocation);
-
-  for (const report of reports) {
-    requestBody.modules.push(report);
-  }
-
-  return requestBody;
+  return {
+    log: `https://github.com/${process.env.GITHUB_REPOSITORY}/actions/runs/${runId}`,
+    modules: reports
+  };
 }
 
 async function main(): Promise<void> {
   const reports: ModularExportBinarySizeRequestBody = await generateReport();
   console.log(JSON.stringify(reports, null, 4));
-  upload(reports, 'size_analysis');
+  upload(reports, RequestEndpoint.MODULAR_EXPORT_BINARY_SIZE);
 }
 main();

scripts/size_report/size_report_helper.ts

@@ -21,11 +21,15 @@ import * as https from 'https';
 export interface RequestBody {
   log: string;
 }
+export enum RequestEndpoint {
+  MODULAR_EXPORT_BINARY_SIZE = 'size_analysis',
+  BINARY_SIZE = 'reports'
+}
 export const runId = process.env.GITHUB_RUN_ID || 'local-run-id';
 
-export const METRICS_SERVICE_URL = process.env.METRICS_SERVICE_URL!;
+const METRICS_SERVICE_URL = process.env.METRICS_SERVICE_URL!;
 
-export function constructRequestPath(requestEndpoint: string): string {
+function constructRequestPath(requestEndpoint: string): string {
   const repo = process.env.GITHUB_REPOSITORY;
   const commit = process.env.GITHUB_SHA;
   let path = `/repos/${repo}/commits/${commit}/${requestEndpoint}`;
@@ -41,7 +45,7 @@ export function constructRequestPath(requestEndpoint: string): string {
   return path;
 }
 
-export function constructRequestOptions(path: string) {
+function constructRequestOptions(path: string) {
   const accessToken = execSync('gcloud auth print-identity-token', {
     encoding: 'utf8'
   }).trim();