Skip to content

Commit d3996d8

Browse files
avolkovisam-gc
authored andcommitted
PR feedback
1 parent 0fd32b6 commit d3996d8

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

packages-exp/auth-exp/src/core/auth/auth_impl.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ export class AuthImpl implements Auth, _FirebaseService {
398398
}
399399

400400
async _redirectUserForId(id: string): Promise<User | null> {
401-
// Make sure we've cleared any pending ppersistence actions if we're not in
401+
// Make sure we've cleared any pending persistence actions if we're not in
402402
// the initializer
403403
if (this._isInitialized) {
404404
await this.queue(async () => {});

packages-exp/auth-exp/src/core/user/token_manager.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import { Auth } from '../../model/auth';
2121
import { IdTokenResponse } from '../../model/id_token';
2222
import { AuthErrorCode } from '../errors';
2323
import { PersistedBlob } from '../persistence';
24-
import { assert, debugFail, fail } from '../util/assert';
24+
import { assert, debugFail } from '../util/assert';
2525

2626
/**
2727
* The number of milliseconds before the official expiration time of a token
@@ -58,11 +58,13 @@ export class StsTokenManager {
5858
return this.accessToken;
5959
}
6060

61-
if (this.accessToken && !this.refreshToken) {
62-
fail(AuthErrorCode.TOKEN_EXPIRED, {
61+
assert(
62+
this.accessToken && !this.refreshToken,
63+
AuthErrorCode.TOKEN_EXPIRED,
64+
{
6365
appName: auth.name
64-
});
65-
}
66+
}
67+
); /* */
6668

6769
await this.refresh(auth, this.refreshToken!);
6870
return this.accessToken;

0 commit comments

Comments
 (0)