Skip to content

Commit d4b9fea

Browse files
committed
update
1 parent 7d46fed commit d4b9fea

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

packages/messaging/src/helpers/externalizePayload.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ describe('externalizePayload', () => {
8585
baz: 'baz'
8686
},
8787
fcmOptions: {
88-
link: 'link',
88+
link: 'https://www.self_orgin.com',
8989
// eslint-disable-next-line camelcase
9090
analytics_label: 'label'
9191
},
@@ -108,7 +108,7 @@ describe('externalizePayload', () => {
108108
baz: 'baz'
109109
},
110110
fcmOptions: {
111-
link: 'link',
111+
link: 'https://www.self_orgin.com',
112112
analyticsLabel: 'label'
113113
},
114114
from: 'from',

packages/messaging/src/helpers/externalizePayload.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,22 +77,23 @@ function propagateFcmOptions(
7777
payload: MessagePayload,
7878
messagePayloadInternal: MessagePayloadInternal
7979
): void {
80-
if (!messagePayloadInternal.fcmOptions) {
80+
// fcmOptions.link value is written into notification.click_action. see more in b/232072111
81+
if (!messagePayloadInternal.fcmOptions && !messagePayloadInternal.notification?.click_action) {
8182
return;
8283
}
8384

8485
payload.fcmOptions = {};
8586

86-
// fcmOptions.link value is written into notification.click_action. see more in b/232072111
8787
const link =
8888
messagePayloadInternal.fcmOptions?.link ??
8989
messagePayloadInternal.notification?.click_action;
90+
9091
if (!!link) {
9192
payload.fcmOptions!.link = link;
9293
}
9394

9495
// eslint-disable-next-line camelcase
95-
const analyticsLabel = messagePayloadInternal.fcmOptions!.analytics_label;
96+
const analyticsLabel = messagePayloadInternal.fcmOptions?.analytics_label;
9697
if (!!analyticsLabel) {
9798
payload.fcmOptions!.analyticsLabel = analyticsLabel;
9899
}

0 commit comments

Comments
 (0)