Share Integration Tests between firestore-exp and the main SDK

Author: schmidt-sebastian

integration/firestore/gulpfile.js

@@ -63,14 +63,36 @@ function copyTests() {
          * This regex is designed to match the following statement used in our
          * firestore integration test suites:
          *
-         * import firebase from '../../util/firebase_export';
+         * import * as firebaseExport from '../../util/firebase_export';
          *
          * It will handle variations in whitespace, single/double quote
          * differences, as well as different paths to a valid firebase_export
          */
-        /import\s+firebase\s+from\s+('|")[^\1]+firebase_export\1;?/,
+        /import\s+\* as firebaseExport\s+from\s+('|")[^\1]+firebase_export\1;?/,
         `import firebase from '${firebaseAppSdk}';
          import '${firebaseFirestoreSdk}';
+    
+         const firebaseExport = firebase.firestore;
+         
+         // Abuse 'window' object to share a global variable between all tests
+         window.appCount = window.appCount ? window.appCount : 0;
+         firebaseExport.newTestFirestore = function(projectId, nameOrApp, settings) {
+           if (nameOrApp === undefined) {
+             nameOrApp = 'test-app-' + window.appCount++;
+           }
+           const app =
+             typeof nameOrApp === 'string'
+               ? firebase.initializeApp({ apiKey: 'fake-api-key', projectId }, nameOrApp)
+               : nameOrApp;
+          
+           const firestore = firebase.firestore(app);
+           if (settings) {
+             firestore.settings(settings);
+           }
+           return firestore;
+         }
+         
+         firebaseExport.usesModularApi = () => false;
          
          if (typeof process === 'undefined') {
            process = { env: { INCLUDE_FIRESTORE_PERSISTENCE: '${isPersistenceEnabled()}' } } as any;

packages/firestore/.idea/runConfigurations/firestore_exp_Tests__Emulator__.xml

@@ -288,7 +288,7 @@ export function disableNetwork(
 export function terminate(
   firestore: firestore.FirebaseFirestore
 ): Promise<void> {
-  _removeServiceInstance(firestore.app, 'firestore/lite');
+  _removeServiceInstance(firestore.app, 'firestore-exp');
   const firestoreImpl = cast(firestore, Firestore);
   return firestoreImpl._terminate();
 }

packages/firestore/.idea/runConfigurations/firestore_exp_Tests__Emulator_w__Mock_Persistence_.xml

@@ -0,0 +1,18 @@
+/**
+ * @license
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import '../../test/integration/api/array_transforms.test';

packages/firestore/exp/src/api/database.ts

@@ -0,0 +1,18 @@
+/**
+ * @license
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import '../../test/integration/api/batch_writes.test';

packages/firestore/exp/test/array_transforms.test.ts

@@ -0,0 +1,18 @@
+/**
+ * @license
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import '../../test/integration/api/cursor.test';

packages/firestore/exp/test/batch_writes.test.ts

@@ -0,0 +1,18 @@
+/**
+ * @license
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import '../../test/integration/api/database.test';

packages/firestore/exp/test/cursor.test.ts

@@ -24,7 +24,9 @@ import * as dependencies from './dependencies.json';
 import * as pkg from '../../package.json';
 import { forEach } from '../../../src/util/obj';
 
-describe('Dependencies', () => {
+// TODO(firestoreexp): Enable once the dependencies are stable
+// eslint-disable-next-line no-restricted-properties
+describe.skip('Dependencies', () => {
   forEach(dependencies, (api, { dependencies }) => {
     it(api, () => {
       return extractDependencies(api, resolve('exp', pkg.main)).then(

packages/firestore/exp/test/database.test.ts

@@ -0,0 +1,18 @@
+/**
+ * @license
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import '../../test/integration/api/fields.test';

packages/firestore/exp/test/deps/verify_dependencies.test.ts

@@ -0,0 +1,18 @@
+/**
+ * @license
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import '../../test/integration/api/get_options.test';