Skip to content

Commit d67da37

Browse files
committed
Remove new TS usage
1 parent 5e8cd5b commit d67da37

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

packages/app/src/platformLoggerService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export class PlatformLoggerService {
3131
.map(provider => {
3232
const service = provider.getImmediate() as VersionService;
3333
const component = provider.getComponent();
34-
if (service && component?.type === ComponentType.VERSION) {
34+
if (service && component && component.type === ComponentType.VERSION) {
3535
const platformString =
3636
// eslint-disable-next-line @typescript-eslint/no-explicit-any
3737
(PLATFORM_LOG_STRING as any)[service.library] ?? service.library;

packages/app/test/platformLogger.test.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,14 @@ describe('Platform Logger Service', () => {
6060
expect(platformInfoString).to.include('vs2/3.02.01');
6161
});
6262
});
63-
63+
6464
describe('Integration Tests', () => {
6565
let firebase: FirebaseNamespace;
66-
66+
6767
beforeEach(() => {
6868
firebase = createFirebaseNamespace();
6969
});
70-
70+
7171
it(`logs core version`, () => {
7272
firebase.initializeApp({});
7373
(firebase as _FirebaseNamespace).INTERNAL.registerComponent(
@@ -86,7 +86,7 @@ describe('Platform Logger Service', () => {
8686
);
8787
(firebase as any)['test-shell']();
8888
});
89-
89+
9090
it(`logs other components' versions`, () => {
9191
firebase.initializeApp({});
9292
(firebase as _FirebaseNamespace).registerVersion('analytics', '1.2.3');
@@ -107,5 +107,4 @@ describe('Platform Logger Service', () => {
107107
(firebase as any)['test-shell']();
108108
});
109109
});
110-
111110
});

0 commit comments

Comments
 (0)