Skip to content

Commit d6b5866

Browse files
Michael Lehenbauerschmidt-sebastian
authored andcommitted
Fix test. (#2147)
1 parent d23d134 commit d6b5866

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

packages/firestore/test/unit/local/remote_document_cache.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ function genericRemoteDocumentCacheTests(
360360
],
361361
version(3)
362362
);
363-
await cache.removeEntry(key('a/2'));
363+
await cache.removeEntry(key('a/2'), version(4));
364364

365365
const changedDocs = await cache.getNewDocumentChanges();
366366
assertMatches(

packages/firestore/test/unit/local/test_remote_document_cache.ts

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -76,14 +76,19 @@ export class TestRemoteDocumentCache {
7676
return this.addEntries([maybeDocument], maybeDocument.version);
7777
}
7878

79-
removeEntry(documentKey: DocumentKey): Promise<void> {
79+
removeEntry(
80+
documentKey: DocumentKey,
81+
version?: SnapshotVersion
82+
): Promise<void> {
8083
return this.persistence.runTransaction(
8184
'removeEntry',
8285
'readwrite-primary',
8386
txn => {
84-
const changeBuffer = this.newChangeBuffer();
87+
const changeBuffer = this.newChangeBuffer(
88+
version ? { trackRemovals: true } : undefined
89+
);
8590
return changeBuffer.getEntry(txn, documentKey).next(() => {
86-
changeBuffer.removeEntry(documentKey);
91+
changeBuffer.removeEntry(documentKey, version);
8792
return changeBuffer.apply(txn);
8893
});
8994
}
@@ -128,7 +133,9 @@ export class TestRemoteDocumentCache {
128133
);
129134
}
130135

131-
newChangeBuffer(): RemoteDocumentChangeBuffer {
132-
return this.cache.newChangeBuffer();
136+
newChangeBuffer(options?: {
137+
trackRemovals: boolean;
138+
}): RemoteDocumentChangeBuffer {
139+
return this.cache.newChangeBuffer(options);
133140
}
134141
}

0 commit comments

Comments
 (0)