Responded to reviewer comments

scottcrossen · scottcrossen · commit d9aff0bae743 · 2020-04-23T14:37:48.000-07:00
diff --git a/packages-exp/auth-compat-exp/index.rn.ts b/packages-exp/auth-compat-exp/index.rn.ts
@@ -25,4 +25,5 @@
 import { AsyncStorage } from 'react-native';
 import { ReactNativePersistence } from '@firebase/auth-exp/src/core/persistence/react_native';
 
-const _reactNativeLocalPersistence = new ReactNativePersistence(AsyncStorage);
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+const reactNativeLocalPersistence = new ReactNativePersistence(AsyncStorage);
diff --git a/packages-exp/auth-compat-exp/react-native.d.ts b/packages-exp/auth-compat-exp/react-native.d.ts
@@ -27,9 +27,9 @@
 
 declare module 'react-native' {
   interface ReactNativeAsyncStorage {
-    setItem(key: string, value: string): Promise<void>
-    getItem(key: string): Promise<string | null>
-    removeItem(key: string): Promise<void>
+    setItem(key: string, value: string): Promise<void>;
+    getItem(key: string): Promise<string | null>;
+    removeItem(key: string): Promise<void>;
   }
   export const AsyncStorage: ReactNativeAsyncStorage;
 }
diff --git a/packages-exp/auth-exp/src/core/persistence/react_native.test.ts b/packages-exp/auth-exp/src/core/persistence/react_native.test.ts
@@ -32,7 +32,7 @@ class FakeAsyncStorage implements ReactNativeAsyncStorage {
 
   async getItem(key: string): Promise<string | null> {
     const value = this.storage[key];
-    return value === undefined ? null : value;
+    return value ?? null;
   }
   async removeItem(key: string): Promise<void> {
     delete this.storage[key];
diff --git a/packages-exp/auth-exp/src/core/persistence/react_native.ts b/packages-exp/auth-exp/src/core/persistence/react_native.ts
@@ -28,11 +28,8 @@ import {ReactNativeAsyncStorage} from '@firebase/auth-types-exp';
  */
 export class ReactNativePersistence implements Persistence {
   readonly type: PersistenceType = PersistenceType.LOCAL;
-  private readonly storage: ReactNativeAsyncStorage;
 
-  constructor(storage: ReactNativeAsyncStorage) {
-    this.storage = storage;
-  }
+  constructor(private readonly storage: ReactNativeAsyncStorage) {}
 
   async isAvailable(): Promise<boolean> {
     try {
diff --git a/packages-exp/auth-types-exp/index.d.ts b/packages-exp/auth-types-exp/index.d.ts
@@ -16,7 +16,7 @@
  */
 
 export interface ReactNativeAsyncStorage {
-  setItem(key: string, value: string): Promise<void>
-  getItem(key: string): Promise<string | null>
-  removeItem(key: string): Promise<void>
+  setItem(key: string, value: string): Promise<void>;
+  getItem(key: string): Promise<string | null>;
+  removeItem(key: string): Promise<void>;
 }
diff --git a/yarn.lock b/yarn.lock
@@ -12590,6 +12590,17 @@ rollup-plugin-typescript2@0.25.3:
     rollup-pluginutils "2.8.1"
     tslib "1.10.0"
 
+rollup-plugin-typescript2@0.26.0:
+  version "0.26.0"
+  resolved "https://registry.npmjs.org/rollup-plugin-typescript2/-/rollup-plugin-typescript2-0.26.0.tgz#cee2b44d51d9623686656d76dc30a73c4de91672"
+  integrity sha512-lUK7XZVG77tu8dmv1L/0LZFlavED/5Yo6e4iMMl6fdox/yKdj4IFRRPPJEXNdmEaT1nDQQeCi7b5IwKHffMNeg==
+  dependencies:
+    find-cache-dir "^3.2.0"
+    fs-extra "8.1.0"
+    resolve "1.15.1"
+    rollup-pluginutils "2.8.2"
+    tslib "1.10.0"
+
 rollup-plugin-typescript2@0.27.0:
   version "0.27.0"
   resolved "https://registry.npmjs.org/rollup-plugin-typescript2/-/rollup-plugin-typescript2-0.27.0.tgz#95ff96f9e07d5000a9d2df4d76b548f9a1f83511"
@@ -12618,7 +12629,7 @@ rollup-pluginutils@2.8.1:
   dependencies:
     estree-walker "^0.6.1"
 
-rollup-pluginutils@^2.5.0, rollup-pluginutils@^2.6.0, rollup-pluginutils@^2.8.1, rollup-pluginutils@^2.8.2:
+rollup-pluginutils@2.8.2, rollup-pluginutils@^2.5.0, rollup-pluginutils@^2.6.0, rollup-pluginutils@^2.8.1, rollup-pluginutils@^2.8.2:
   version "2.8.2"
   resolved "https://registry.npmjs.org/rollup-pluginutils/-/rollup-pluginutils-2.8.2.tgz#72f2af0748b592364dbd3389e600e5a9444a351e"
   integrity sha512-EEp9NhnUkwY8aif6bxgovPHMoMoNr2FulJziTndpt5H9RdwC47GSGuII9XxpSdzVGM0GWrNPHV6ie1LTNJPaLQ==
@@ -15536,4 +15547,4 @@ zip-stream@^2.1.2:
   dependencies:
     archiver-utils "^2.1.0"
     compress-commons "^2.1.1"
-    readable-stream "^3.4.0"
+    readable-stream "^3.4.0"

Original file line number	Diff line number	Diff line change
`@@ -27,9 +27,9 @@`
`27`	`27`
`28`	`28`	`declare module 'react-native' {`
`29`	`29`	`interface ReactNativeAsyncStorage {`
`30`		`- setItem(key: string, value: string): Promise<void>`
`31`		`- getItem(key: string): Promise<string \| null>`
`32`		`- removeItem(key: string): Promise<void>`
	`30`	`+ setItem(key: string, value: string): Promise<void>;`
	`31`	`+ getItem(key: string): Promise<string \| null>;`
	`32`	`+ removeItem(key: string): Promise<void>;`
`33`	`33`	`}`
`34`	`34`	`export const AsyncStorage: ReactNativeAsyncStorage;`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ class FakeAsyncStorage implements ReactNativeAsyncStorage {`
`32`	`32`
`33`	`33`	`async getItem(key: string): Promise<string \| null> {`
`34`	`34`	`const value = this.storage[key];`
`35`		`- return value === undefined ? null : value;`
	`35`	`+ return value ?? null;`
`36`	`36`	`}`
`37`	`37`	`async removeItem(key: string): Promise<void> {`
`38`	`38`	`delete this.storage[key];`