Skip to content

Commit dc88dd5

Browse files
committed
resolve comments
1 parent ffe6711 commit dc88dd5

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

.changeset/cool-grapes-attend.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@firebase/firestore': patch
3+
---
4+
5+
Fix Firestore failing to raise initial snapshot from empty local cache result

packages/firestore/test/unit/specs/listen_spec.test.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1759,14 +1759,9 @@ describeSpec('Listens:', [], () => {
17591759
.userListens(query1)
17601760
.watchAcksFull(query1, 1000)
17611761
.expectEvents(query1, { fromCache: false })
1762-
// Query is shared in second client
1763-
.client(1)
1764-
.expectListen(query1)
1765-
.client(0)
17661762
.userUnlistens(query1)
17671763
.watchRemoves(query1)
17681764
.client(1)
1769-
.expectUnlisten(query1)
17701765
// Re-listen to the query in second client and verify that the empty
17711766
// snapshot is raised from cache.
17721767
.userListens(query1, { resumeToken: 'resume-token-1000' })
@@ -1810,7 +1805,6 @@ describeSpec('Listens:', [], () => {
18101805
.writeAcks('collection/a', 2000)
18111806
.watchAcksFull(query1, 2000, doc1Deleted)
18121807
.client(1)
1813-
.expectListen(query1, { resumeToken: 'resume-token-2000' })
18141808
.expectEvents(query1, { fromCache: false })
18151809
);
18161810
}

repo-scripts/prune-dts/tests/firestore.input.d.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4988,8 +4988,7 @@ declare class TargetChange {
49884988
*/
49894989
static createSynthesizedTargetChangeForCurrentChange(
49904990
targetId: TargetId,
4991-
current: boolean,
4992-
resumeToken: ByteString
4991+
current: boolean
49934992
): TargetChange;
49944993
}
49954994

0 commit comments

Comments
 (0)