Merge branch 'master' into fis-compat

Author: ChaoqunCHEN

.changeset/large-books-call.md

@@ -0,0 +1,5 @@
+---
+"@firebase/auth": patch
+---
+
+Update auth token logic to rely on device clock time instead of server time. This fixes an issue seen when a device's clock is skewed by a lot: https://github.com/firebase/firebase-js-sdk/issues/3222

.changeset/rich-birds-wink.md

@@ -0,0 +1,5 @@
+---
+"@firebase/firestore": patch
+---
+
+Fixes an issue that prevented the SDK from automatically retrieving custom User claims.

.changeset/thick-snails-appear.md

@@ -0,0 +1,42 @@
+---
+name: 🧪 Alpha SDK bug report
+about: Have you found a bug in one of our pre-release or alpha SDKs? File it here.
+title: ""
+labels: "alpha"
+assignees: ""
+---
+
+<!-- Step 1 [READ THIS] -->
+<!--
+Are you in the right place?
+  * For issues or feature requests related to __the code in this repository__
+    file a Github issue.
+  * If you are not yet participating in our Alpha and would like to join, use this form:
+    https://forms.gle/bKBEm48W8EMPLaUp9
+  * For general Alpha discussion, use the google group:
+    https://groups.google.com/g/firebase-js-sdk-testers
+-->
+
+<!-- Step 2 -->
+
+### [REQUIRED] Describe your environment
+
+  * Operating System version: _____
+  * Browser version: _____
+  * Firebase SDK version: _____
+  * Firebase Product: _____ (auth, database, storage, etc)
+
+<!-- Step 3 -->
+
+### [REQUIRED] Describe the problem
+
+#### Steps to reproduce:
+<!--
+  What happened? How can we make the problem occur?
+  This could be a description, log/console output, etc.
+-->
+#### Relevant Code:
+
+```javascript
+// TODO(you): code here to reproduce the problem
+```

.changeset/wicked-actors-clap.md

@@ -1,3 +1,11 @@
+---
+name: 🐞 Bug report
+about: Found a bug in the JS SDK? File it here.
+title: ""
+labels: ""
+assignees: ""
+---
+
 <!-- Step 1 [READ THIS] -->
 <!--
 Are you in the right place?
@@ -33,12 +41,6 @@ Are you in the right place?
 -->
 #### Relevant Code:
 
-<!--
-  Reproduce the issue on StackBlitz and provide your forked URL
-  or give us some sample code below
--->
-https://stackblitz.com/fork/firebase-issue-sandbox
-
 ```javascript
 // TODO(you): code here to reproduce the problem
 ```

.github/ISSUE_TEMPLATE/alpha_bug_report.md

@@ -0,0 +1,5 @@
+blank_issues_enabled: false
+contact_links:
+  - name: 🔥 Firebase Support
+    url: https://firebase.google.com/support/
+    about: If you have an urgent issue with your app in production, please contact support.

.github/ISSUE_TEMPLATE.md renamed to .github/ISSUE_TEMPLATE/bug_report.md

@@ -26,7 +26,7 @@ jobs:
     - name: yarn build
       run: yarn build
     - name: Set start timestamp env var
-      run: echo "::set-env name=FIREBASE_CI_TEST_START_TIME::$(date +%s)"
+      run: echo "FIREBASE_CI_TEST_START_TIME=$(date +%s)" >> $GITHUB_ENV
     - name: Run unit tests
       run: |
         xvfb-run yarn test:ci

.github/ISSUE_TEMPLATE/config.yml

@@ -146,7 +146,7 @@ export function fetchSignInMethodsForEmail(auth: externs.Auth, email: string): P
 export function getAdditionalUserInfo(userCredential: externs.UserCredential): externs.AdditionalUserInfo | null;
 
 // @public
-export function getAuth(app?: FirebaseApp): Auth;
+export function getAuth(app: FirebaseApp): Auth;
 
 // @public
 export function getIdToken(user: externs.User, forceRefresh?: boolean): Promise<string>;
@@ -186,7 +186,7 @@ export const indexedDBLocalPersistence: externs.Persistence;
 // Warning: (ae-forgotten-export) The symbol "Dependencies" needs to be exported by the entry point index.d.ts
 //
 // @public (undocumented)
-export function initializeAuth(app?: FirebaseApp, deps?: Dependencies): externs.Auth;
+export function initializeAuth(app: FirebaseApp, deps?: Dependencies): externs.Auth;
 
 // @public
 export const inMemoryPersistence: externs.Persistence;
@@ -247,8 +247,10 @@ export class OAuthProvider implements externs.AuthProvider {
     constructor(providerId: string);
     addScope(scope: string): externs.AuthProvider;
     credential(params: OAuthCredentialOptions): externs.OAuthCredential;
+    static credentialFromError(error: FirebaseError): externs.OAuthCredential | null;
     // (undocumented)
     static credentialFromJSON(json: object | string): externs.OAuthCredential;
+    static credentialFromResult(userCredential: externs.UserCredential): externs.OAuthCredential | null;
     // @internal (undocumented)
     defaultLanguageCode: string | null;
     getCustomParameters(): CustomParameters;
@@ -363,7 +365,7 @@ export function sendPasswordResetEmail(auth: externs.Auth, email: string, action
 export function sendSignInLinkToEmail(auth: externs.Auth, email: string, actionCodeSettings?: externs.ActionCodeSettings): Promise<void>;
 
 // @public
-export function setPersistence(auth: externs.Auth, persistence: externs.Persistence): void;
+export function setPersistence(auth: externs.Auth, persistence: externs.Persistence): Promise<void>;
 
 // @public
 export function signInAnonymously(auth: externs.Auth): Promise<externs.UserCredential>;

.github/workflows/test-all.yml

@@ -11,7 +11,6 @@ import { _FirebaseService } from '@firebase/app-types-exp';
 import { LogLevelString as LogLevel } from '@firebase/logger';
 import { Provider } from '@firebase/component';
 import { SetOptions as SetOptions_2 } from '@firebase/firestore-types';
-import { SnapshotMetadata as SnapshotMetadata_2 } from '@firebase/firestore-types';
 
 // @public
 export function addDoc<T>(reference: CollectionReference<T>, data: T): Promise<DocumentReference<T>>;
@@ -440,11 +439,11 @@ export interface SnapshotListenOptions {
 }
 
 // @public
-export class SnapshotMetadata implements SnapshotMetadata_2 {
+export class SnapshotMetadata {
     constructor(hasPendingWrites: boolean, fromCache: boolean);
     readonly fromCache: boolean;
     readonly hasPendingWrites: boolean;
-    isEqual(other: SnapshotMetadata_2): boolean;
+    isEqual(other: SnapshotMetadata): boolean;
 }
 
 // @public

common/api-review/auth-exp.api.md

@@ -168,8 +168,10 @@ export abstract class FieldValue {
     abstract _toFieldTransform(context: ParseContext): FieldTransform | null;
 }
 
+// Warning: (ae-forgotten-export) The symbol "FirestoreService" needs to be exported by the entry point index.d.ts
+//
 // @public
-export class FirebaseFirestore implements _FirebaseService {
+export class FirebaseFirestore implements FirestoreService {
     constructor(databaseIdOrApp: DatabaseId | FirebaseApp, authProvider: Provider<FirebaseAuthInternalName>);
     get app(): FirebaseApp;
     // Warning: (ae-forgotten-export) The symbol "CredentialsProvider" needs to be exported by the entry point index.d.ts