Skip to content

Commit e277ce8

Browse files
committed
remove purposeful failures
1 parent c74725d commit e277ce8

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

.github/workflows/test-all.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ env:
2525
# the beahvior to use the new URLs.
2626
CHROMEDRIVER_CDNURL: https://googlechromelabs.github.io/
2727
CHROMEDRIVER_CDNBINARIESURL: https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/
28-
CHROME_VALIDATED_VERSION: blinux-120.0.6099.71
28+
CHROME_VALIDATED_VERSION: linux-120.0.6099.71
2929
CHROME_VERSION_MISMATCH_MESSAGE: "The Chrome version doesn't match the previously validated version. Consider updating CHROME_VALIDATED_VERSION in the GitHub workflow if tests pass."
3030
artifactRetentionDays: 14
3131
# Bump Node memory limit

.github/workflows/test-changed-auth.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ env:
2323
# the beahvior to use the new URLs.
2424
CHROMEDRIVER_CDNURL: https://googlechromelabs.github.io/
2525
CHROMEDRIVER_CDNBINARIESURL: https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/
26-
CHROME_VALIDATED_VERSION: blinux-120.0.6099.71
26+
CHROME_VALIDATED_VERSION: linux-120.0.6099.71
2727
# Bump Node memory limit
2828
NODE_OPTIONS: "--max_old_space_size=4096"
2929

packages/auth/test/integration/flows/anonymous.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ describe('Integration test: anonymous auth', () => {
5252
expect(userCred.operationType).to.eq(OperationType.SIGN_IN);
5353

5454
const user = userCred.user;
55-
expect(user.isAnonymous).to.be.false;
55+
expect(user.isAnonymous).to.be.true;
5656
expect(user.uid).to.be.a('string');
5757
});
5858

scripts/run_tests_in_ci.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,7 @@ const argv = yargs.options({
9191
if(process.env.CHROME_VERSION_NOTES) {
9292
console.error()
9393
console.error(process.env.CHROME_VERSION_NOTES)
94-
console.error(" yo yo ho ho ")
95-
} else {
96-
94+
console.error()
9795
}
9896

9997
writeLogs('Failure', name, stdout + '\n' + stderr);

0 commit comments

Comments
 (0)