Skip to content

Commit e2a1930

Browse files
committed
correct deleteInstallations funciton name
1 parent aa2c9a0 commit e2a1930

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

packages-exp/installations-exp/src/api/delete-installation.test.ts renamed to packages-exp/installations-exp/src/api/delete-installations.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import { getFakeInstallations } from '../testing/fake-generators';
3333
import '../testing/setup';
3434
import { ErrorCode } from '../util/errors';
3535
import { sleep } from '../util/sleep';
36-
import { deleteInstallation } from './delete-installation';
36+
import { deleteInstallations } from './delete-installations';
3737

3838
const FID = 'children-of-the-damned';
3939

@@ -56,7 +56,7 @@ describe('deleteInstallation', () => {
5656
});
5757

5858
it('resolves without calling server API if there is no installation', async () => {
59-
await expect(deleteInstallation(installations)).to.be.fulfilled;
59+
await expect(deleteInstallations(installations)).to.be.fulfilled;
6060
expect(deleteInstallationRequestSpy).not.to.have.been.called;
6161
});
6262

@@ -67,7 +67,7 @@ describe('deleteInstallation', () => {
6767
};
6868
await set(installations.appConfig, entry);
6969

70-
await expect(deleteInstallation(installations)).to.be.fulfilled;
70+
await expect(deleteInstallations(installations)).to.be.fulfilled;
7171
expect(deleteInstallationRequestSpy).not.to.have.been.called;
7272
await expect(get(installations.appConfig)).to.eventually.be.undefined;
7373
});
@@ -80,7 +80,7 @@ describe('deleteInstallation', () => {
8080
};
8181
await set(installations.appConfig, entry);
8282

83-
await expect(deleteInstallation(installations)).to.be.rejectedWith(
83+
await expect(deleteInstallations(installations)).to.be.rejectedWith(
8484
ErrorCode.DELETE_PENDING_REGISTRATION
8585
);
8686
expect(deleteInstallationRequestSpy).not.to.have.been.called;
@@ -101,7 +101,7 @@ describe('deleteInstallation', () => {
101101
await set(installations.appConfig, entry);
102102
stub(navigator, 'onLine').value(false);
103103

104-
await expect(deleteInstallation(installations)).to.be.rejectedWith(
104+
await expect(deleteInstallations(installations)).to.be.rejectedWith(
105105
ErrorCode.APP_OFFLINE
106106
);
107107
expect(deleteInstallationRequestSpy).not.to.have.been.called;
@@ -121,7 +121,7 @@ describe('deleteInstallation', () => {
121121
};
122122
await set(installations.appConfig, entry);
123123

124-
await expect(deleteInstallation(installations)).to.be.fulfilled;
124+
await expect(deleteInstallations(installations)).to.be.fulfilled;
125125
expect(deleteInstallationRequestSpy).to.have.been.calledOnceWith(
126126
installations.appConfig,
127127
entry

packages-exp/installations-exp/src/api/delete-installation.ts renamed to packages-exp/installations-exp/src/api/delete-installations.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import { RequestStatus } from '../interfaces/installation-entry';
2121
import { ERROR_FACTORY, ErrorCode } from '../util/errors';
2222
import { FirebaseInstallations } from '@firebase/installations-types-exp';
2323

24-
export async function deleteInstallation(
24+
export async function deleteInstallations(
2525
installations: FirebaseInstallations
2626
): Promise<void> {
2727
const { appConfig } = installations;

packages-exp/installations-exp/src/api/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@
1717

1818
export * from './get-id';
1919
export * from './get-token';
20-
export * from './delete-installation';
20+
export * from './delete-installations';
2121
export * from './on-id-change';
2222
export * from './get-installations';

packages-exp/installations-exp/src/functions/config.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import { registerVersion, _registerComponent } from '@firebase/app-exp';
1919
import { _FirebaseService } from '@firebase/app-types-exp';
2020
import { Component, ComponentType } from '@firebase/component';
21-
import { getInstallations, deleteInstallation } from '../api/index';
21+
import { getInstallations, deleteInstallations } from '../api/index';
2222

2323
import { name, version } from '../../package.json';
2424

@@ -35,7 +35,7 @@ export function registerInstallations(): void {
3535
const installations = getInstallations(app);
3636
const installationsService: _FirebaseService = {
3737
app,
38-
delete: () => deleteInstallation(installations)
38+
delete: () => deleteInstallations(installations)
3939
};
4040

4141
return installationsService;

0 commit comments

Comments
 (0)