WIP Tree-Shakeable Mutations

Author: schmidt-sebastian

packages/firestore/lite/test/dependencies.json

@@ -31,6 +31,7 @@ import {
 } from '../model/transform_operation';
 import { ParseContext, parseData, UserDataSource } from './user_data_reader';
 import { debugAssert } from '../util/assert';
+import { toNumber } from '../remote/serializer';
 
 /**
  * An opaque base class for FieldValue sentinel objects in our public API that
@@ -188,17 +189,10 @@ export class NumericIncrementFieldValueImpl extends SerializableFieldValue {
   }
 
   _toFieldTransform(context: ParseContext): FieldTransform {
-    const parseContext = createSentinelChildContext(
-      this,
-      context,
-      /*array=*/ false
-    );
-    const operand = parseData(this._operand, parseContext)!;
-    const numericIncrement = new NumericIncrementTransformOperation(
-      context.serializer,
-      operand
+    return new FieldTransform(
+      context.path!,
+      toNumber(context.serializer, this._operand)
     );
-    return new FieldTransform(context.path!, numericIncrement);
   }
 
   isEqual(other: FieldValue): boolean {

packages/firestore/src/api/field_value.ts

@@ -35,7 +35,7 @@ import { ResourcePath } from '../model/path';
 import { debugAssert } from '../util/assert';
 import { IndexManager } from './index_manager';
 import { MutationQueue } from './mutation_queue';
-import { PatchMutation } from '../model/mutation';
+import { applyMutationToLocalView, PatchMutation } from '../model/mutation';
 import { PersistenceTransaction } from './persistence';
 import { PersistencePromise } from './persistence_promise';
 import { RemoteDocumentCache } from './remote_document_cache';
@@ -258,7 +258,8 @@ export class LocalDocumentsView {
             for (const mutation of batch.mutations) {
               const key = mutation.key;
               const baseDoc = results.get(key);
-              const mutatedDoc = mutation.applyToLocalView(
+              const mutatedDoc = applyMutationToLocalView(
+                mutation,
                 baseDoc,
                 baseDoc,
                 batch.localWriteTime

packages/firestore/src/local/local_documents_view.ts

@@ -30,7 +30,12 @@ import {
 } from '../model/collections';
 import { MaybeDocument, NoDocument } from '../model/document';
 import { DocumentKey } from '../model/document_key';
-import { Mutation, PatchMutation, Precondition } from '../model/mutation';
+import {
+  Mutation,
+  PatchMutation,
+  Precondition,
+  extractBaseValue
+} from '../model/mutation';
 import {
   BATCHID_UNKNOWN,
   MutationBatch,
@@ -449,7 +454,8 @@ class LocalStoreImpl implements LocalStore {
           const baseMutations: Mutation[] = [];
 
           for (const mutation of mutations) {
-            const baseValue = mutation.extractBaseValue(
+            const baseValue = extractBaseValue(
+              mutation,
               existingDocs.get(mutation.key)
             );
             if (baseValue != null) {