Skip to content

Commit e5fc290

Browse files
authored
Disable nightly run with PR (#7876)
* Disable nightly run with PR * triggers a firestore change * feedback * try again
1 parent 16728cf commit e5fc290

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.github/workflows/test-changed-firestore.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@
1414

1515
name: Test Firestore
1616

17-
on: pull_request
17+
on:
18+
workflow_dispatch:
19+
pull_request:
1820

1921
env:
2022
artifactRetentionDays: 14
@@ -138,7 +140,7 @@ jobs:
138140
test-name: ["test:browser:nightly"]
139141
runs-on: ubuntu-latest
140142
needs: build
141-
if: ${{ needs.build.outputs.changed == 'true'}}
143+
if: ${{ github.event_name != 'pull_request' }}
142144
steps:
143145
- name: Set up Node (16)
144146
uses: actions/setup-node@v3

packages/firestore/test/integration/api/query.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ apiDescribe('Queries', persistence => {
411411
});
412412
});
413413

414-
it('maintains correct DocumentChange indices', async () => {
414+
it('maintains correct DocumentChange indexes', async () => {
415415
const testDocs = {
416416
'a': { order: 1 },
417417
'b': { order: 2 },

0 commit comments

Comments
 (0)