Fix Firestore Performance spec test (#2594)

schmidt-sebastian · web-flow · commit e6cb0c268435 · 2020-02-04T12:03:57.000-08:00
These tests are only run on demand. One of the tests broke when we stopped accepting zero version documents in the RemoteDocumentCache
diff --git a/packages/firestore/test/unit/specs/perf_spec.test.ts b/packages/firestore/test/unit/specs/perf_spec.test.ts
@@ -34,7 +34,7 @@ describeSpec(
       for (let i = 0; i < STEP_COUNT; ++i) {
         steps
           .userSets(`collection/{i}`, { doc: i })
-          .writeAcks(`collection/{i}`, i);
+          .writeAcks(`collection/{i}`, i + 1); // Prevent zero version
       }
       return steps;
     });

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ describeSpec(`
`34`	`34`	`for (let i = 0; i < STEP_COUNT; ++i) {`
`35`	`35`	`steps`
`36`	`36`	.userSets(`collection/{i}`, { doc: i })
`37`		- .writeAcks(`collection/{i}`, i);
	`37`	+ .writeAcks(`collection/{i}`, i + 1); // Prevent zero version
`38`	`38`	`}`
`39`	`39`	`return steps;`
`40`	`40`	`});`