Merge branch 'markduckworth/or-queries-pr-9' into markduckworth/or-queries-relaxing-in-restrictions

Author: MarkDuckworth

common/api-review/firestore-lite.api.md

@@ -244,10 +244,6 @@ export class QueryCompositeFilterConstraint {
 // @public
 export abstract class QueryConstraint {
     abstract readonly type: QueryConstraintType;
-    /**
-     * Takes the provided {@link Query} and returns a copy of the {@link Query} with this
-     * {@link AppliableConstraint} applied.
-     */
 }
 
 // @public

common/api-review/firestore.api.md

@@ -373,10 +373,6 @@ export class QueryCompositeFilterConstraint {
 // @public
 export abstract class QueryConstraint {
     abstract readonly type: QueryConstraintType;
-    /**
-     * Takes the provided {@link Query} and returns a copy of the {@link Query} with this
-     * {@link AppliableConstraint} applied.
-     */
 }
 
 // @public

packages/firestore/src/lite-api/query.ts

@@ -101,14 +101,20 @@ export abstract class AppliableConstraint {
 /**
  * A `QueryConstraint` is used to narrow the set of documents returned by a
  * Firestore query. `QueryConstraint`s are created by invoking {@link where},
- * {@link orderBy}, {@link startAt:}, {@link startAfter}, {@link
+ * {@link orderBy}, {@link startAt}, {@link startAfter}, {@link
  * endBefore}, {@link endAt}, {@link limit}, {@link limitToLast} and
  * can then be passed to {@link query} to create a new query instance that
  * also contains this `QueryConstraint`.
  */
 export abstract class QueryConstraint extends AppliableConstraint {
   /** The type of this query constraint */
   abstract readonly type: QueryConstraintType;
+
+  /**
+   * Takes the provided {@link Query} and returns a copy of the {@link Query} with this
+   * {@link AppliableConstraint} applied.
+   */
+  abstract _apply<T>(query: Query<T>): Query<T>;
 }
 
 /**
@@ -332,10 +338,9 @@ export class QueryCompositeFilterConstraint extends AppliableConstraint {
 }
 
 /**
- * `QueryNonFilterConstraint` is a helper union type that represents all
- * QueryConstraints which do not inherit from QueryFieldFilterConstraint. These
- * are used to narrow or order the set of documents returned by a Firestore
- * query, but they do not explicitly filter on a document field.
+ * `QueryNonFilterConstraint` is a helper union type that represents
+ * QueryConstraints which are used to narrow or order the set of documents,
+ * but that do not explicitly filter on a document field.
  * `QueryNonFilterConstraint`s are created by invoking {@link orderBy},
  * {@link startAt}, {@link startAfter}, {@link endBefore}, {@link endAt},
  * {@link limit} or {@link limitToLast} and can then be passed to {@link query}