Merge 51cedc5 into 6d31930

Author: wu-hui

packages/firestore/src/api/cache_config.ts

@@ -62,7 +62,9 @@ class MemoryLocalCacheImpl implements MemoryLocalCache {
       this._offlineComponentProvider =
         settings.garbageCollector._offlineComponentProvider;
     } else {
-      this._offlineComponentProvider = new MemoryOfflineComponentProvider();
+      this._offlineComponentProvider = new LruGcMemoryOfflineComponentProvider(
+        undefined
+      );
     }
   }
 

packages/firestore/src/core/firestore_client.ts

@@ -64,6 +64,7 @@ import { Aggregate } from './aggregate';
 import { NamedQuery } from './bundle';
 import {
   ComponentConfiguration,
+  LruGcMemoryOfflineComponentProvider,
   MemoryOfflineComponentProvider,
   OfflineComponentProvider,
   OnlineComponentProvider
@@ -339,7 +340,7 @@ async function ensureOfflineComponents(
       logDebug(LOG_TAG, 'Using default OfflineComponentProvider');
       await setOfflineComponentProvider(
         client,
-        new MemoryOfflineComponentProvider()
+        new LruGcMemoryOfflineComponentProvider(undefined)
       );
     }
   }

packages/firestore/test/integration/api/database.test.ts

@@ -1967,4 +1967,17 @@ apiDescribe('Database', persistence => {
       });
     });
   });
+
+  it('Lru GC is enabled by default.', () => {
+    const initialData = { key: 'value' };
+    return withTestDb(persistence, async db => {
+      const docRef = doc(collection(db, 'test-collection'));
+      await setDoc(docRef, initialData);
+      return getDocFromCache(docRef).then(doc => {
+        expect(doc.exists()).to.be.true;
+        expect(doc.metadata.fromCache).to.be.true;
+        expect(doc.data()).to.deep.equal(initialData);
+      });
+    });
+  });
 });

packages/firestore/test/integration/util/helpers.ts

@@ -181,9 +181,7 @@ function apiDescribeInternal(
   message: string,
   testSuite: (persistence: PersistenceMode) => void
 ): void {
-  const persistenceModes: PersistenceMode[] = [
-    new MemoryEagerPersistenceMode()
-  ];
+  const persistenceModes: PersistenceMode[] = [new MemoryLruPersistenceMode()];
   if (isPersistenceAvailable()) {
     persistenceModes.push(new IndexedDbPersistenceMode());
   }