Polish new Firestore GA jobs

Author: wu-hui

.github/workflows/test-changed-firestore.yml

@@ -48,7 +48,7 @@ jobs:
       - name: Archive build
         if: ${{ !cancelled() && steps.build.outcome != 'success' }}
         run: |
-          tar -cf build.tar --exclude="\.git" .
+          tar -cf build.tar --exclude=.git .
           gzip build.tar
       - name: Upload build archive
         if: ${{ !cancelled() && steps.build.outcome != 'success' }}
@@ -81,8 +81,7 @@ jobs:
       - name: Bump Node memory limit
         run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
       - name: Test setup and yarn install
-        run: |
-          cp config/ci.config.json config/project.json
+        run: cp config/ci.config.json config/project.json
       - name: Run compat tests
         run: cd packages/firestore-compat && yarn run test:ci
 
@@ -112,11 +111,42 @@ jobs:
       - name: Bump Node memory limit
         run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
       - name: Test setup and yarn install
-        run: |
-          cp config/ci.config.json config/project.json
+        run: cp config/ci.config.json config/project.json
       - name: Run tests
         run: cd packages/firestore && yarn run ${{ matrix.test-name }}
 
+  compat-test-firefox:
+    name: Test Firestore Compatible on Firefox
+    runs-on: ubuntu-latest
+    # Whatever version of Firefox comes with 22.04 is causing Firefox
+    # startup to hang when launched by karma. Need to look further into
+    # why.
+    runs-on: ubuntu-20.04
+    needs: build
+    if: ${{ needs.build.outputs.changed == 'true'}}
+    steps:
+      - name: install Firefox stable
+        run: |
+          sudo apt-get update
+          sudo apt-get install firefox
+      - name: Set up Node (14)
+        uses: actions/setup-node@v3
+        with:
+          node-version: 14.x
+      - name: Download build archive
+        uses: actions/download-artifact@v3
+        with:
+          name: build.tar.gz
+      - name: Unzip build artifact
+        run: tar xf build.tar.gz
+      - name: Bump Node memory limit
+        run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
+      - name: Test setup and yarn install
+        run: cp config/ci.config.json config/project.json
+      - name: Run compat tests
+        run: cd packages/firestore-compat && yarn run test:ci
+        env:
+          BROWSERS: 'Firefox'
 
   test-firefox:
     name: Test Firestore on Firefox
@@ -147,8 +177,7 @@ jobs:
       - name: Bump Node memory limit
         run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
       - name: Test setup and yarn install
-        run: |
-          cp config/ci.config.json config/project.json
+        run: cp config/ci.config.json config/project.json
       - name: Run tests
         run: cd packages/firestore && xvfb-run yarn run ${{ matrix.test-name }}
         env:

packages/firestore/test/integration/api/database.test.ts

@@ -831,6 +831,7 @@ apiDescribe('Database', persistence => {
           expect(snap.data()).to.deep.equal(changedData);
           // This event could be a metadata change for fromCache as well.
           // We comment this line out to reduce flakiness.
+
           // TODO(b/295872012): Figure out a way to check for all scenarios.
           // expect(snap.metadata.hasPendingWrites).to.be.false;
         });