Fix up tests

Author: hsubox76

packages/storage/compat/reference.ts

@@ -19,7 +19,7 @@ import {
   Reference,
   getChild,
   getParent,
-  uploadBytes,
+  uploadBytesResumable,
   uploadString,
   list,
   listAll,
@@ -89,7 +89,7 @@ export class ReferenceCompat implements types.Reference {
   ): types.UploadTask {
     this._throwIfRoot('put');
     return new UploadTaskCompat(
-      uploadBytes(this._delegate, data, metadata),
+      uploadBytesResumable(this._delegate, data, metadata),
       this
     );
   }

packages/storage/exp/index.ts

@@ -29,7 +29,7 @@ import { name, version } from '../package.json';
 
 export { ref } from '../src/service';
 export {
-  uploadBytes,
+  uploadBytesResumable,
   uploadString,
   getMetadata,
   updateMetadata,

packages/storage/rollup.config.exp.js

@@ -21,6 +21,7 @@ import typescript from 'typescript';
 import pkgExp from './exp/package.json';
 import pkg from './package.json';
 import path from 'path';
+import { importPathTransformer } from '../../scripts/exp/ts-transform-import-path';
 
 const deps = Object.keys(
   Object.assign({}, pkg.peerDependencies, pkg.dependencies)
@@ -34,7 +35,8 @@ const plugins = [
         target: 'es2017'
       }
     },
-    abortOnError: false
+    abortOnError: false,
+    transformers: [importPathTransformer]
   }),
   json({ preferConst: true })
 ];

packages/storage/src/implementation/error.ts

@@ -24,7 +24,7 @@ export class FirebaseStorageError implements Error {
 
   constructor(code: Code, message: string) {
     this.code_ = prependCode(code);
-    this.message_ = 'Firebase Storage: ' + message;
+    this.message_ = `Firebase Storage: ${message} (${this.code_})`;
     this.serverResponse_ = null;
     this.name_ = 'FirebaseError';
   }

packages/storage/src/reference.ts

@@ -130,12 +130,12 @@ export class Reference {
  * @returns An UploadTask that lets you control and
  *     observe the upload.
  */
-export function uploadBytes(
+export function uploadBytesResumable(
   ref: Reference,
   data: Blob | Uint8Array | ArrayBuffer,
   metadata: Metadata | null = null
 ): UploadTask {
-  ref._throwIfRoot('uploadBytes');
+  ref._throwIfRoot('uploadBytesResumable');
   return new UploadTask(ref, new FbsBlob(data), metadata);
 }
 

packages/storage/src/service.ts

@@ -102,18 +102,8 @@ export function ref(
         'To use ref(service, url), the first argument must be a Storage instance.'
       );
     }
-  } else if (pathOrUrl) {
-    return refFromPath(serviceOrRef, pathOrUrl);
   } else {
-    // pathOrUrl param not provided
-    if (serviceOrRef instanceof StorageService) {
-      return refFromPath(serviceOrRef);
-    } else {
-      throw invalidArgument(
-        'To get the root reference, a Storage instance must be provided as' +
-          ' the param. Example: ref(storageInstance);'
-      );
-    }
+    return refFromPath(serviceOrRef, pathOrUrl);
   }
 }