Fix build

Author: schmidt-sebastian

common/api-review/firestore-exp.api.md

@@ -53,6 +53,8 @@ export class CollectionReference<T = DocumentData> extends Query<T> {
     get path(): string;
     // (undocumented)
     readonly type = "collection";
+    withConverter(converter: null): CollectionReference<DocumentData>;
+    // (undocumented)
     withConverter<U>(converter: FirestoreDataConverter<U>): CollectionReference<U>;
 }
 
@@ -101,6 +103,8 @@ export class DocumentReference<T = DocumentData> {
     get parent(): CollectionReference<T>;
     get path(): string;
     readonly type = "document";
+    withConverter(converter: null): DocumentReference<DocumentData>;
+    // (undocumented)
     withConverter<U>(converter: FirestoreDataConverter<U>): DocumentReference<U>;
 }
 
@@ -318,6 +322,8 @@ export class Query<T = DocumentData> {
     protected constructor();
     readonly firestore: FirebaseFirestore;
     readonly type: 'query' | 'collection';
+    withConverter(converter: null): Query<DocumentData>;
+    // (undocumented)
     withConverter<U>(converter: FirestoreDataConverter<U>): Query<U>;
 }
 

common/api-review/firestore-lite.api.md

@@ -47,6 +47,8 @@ export class CollectionReference<T = DocumentData> extends Query<T> {
     get path(): string;
     // (undocumented)
     readonly type = "collection";
+    withConverter(converter: null): CollectionReference<DocumentData>;
+    // (undocumented)
     withConverter<U>(converter: FirestoreDataConverter<U>): CollectionReference<U>;
 }
 
@@ -81,6 +83,8 @@ export class DocumentReference<T = DocumentData> {
     get parent(): CollectionReference<T>;
     get path(): string;
     readonly type = "document";
+    withConverter(converter: null): DocumentReference<DocumentData>;
+    // (undocumented)
     withConverter<U>(converter: FirestoreDataConverter<U>): DocumentReference<U>;
 }
 
@@ -195,6 +199,8 @@ export class Query<T = DocumentData> {
     protected constructor();
     readonly firestore: FirebaseFirestore;
     readonly type: 'query' | 'collection';
+    withConverter(converter: null): Query<DocumentData>;
+    // (undocumented)
     withConverter<U>(converter: FirestoreDataConverter<U>): Query<U>;
 }
 

packages/firestore/test/integration/api_internal/transaction.test.ts

@@ -33,7 +33,7 @@ apiDescribe(
       const transactionPromises: Array<Promise<void>> = [];
       const readPromises: Array<Promise<void>> = [];
       // A barrier to make sure every transaction reaches the same spot.
-      const barrier = new Deferred();
+      const barrier = new Deferred<void>();
       let started = 0;
 
       return integrationHelpers.withTestDb(persistence, db => {
@@ -90,7 +90,7 @@ apiDescribe(
       const transactionPromises: Array<Promise<void>> = [];
       const readPromises: Array<Promise<void>> = [];
       // A barrier to make sure every transaction reaches the same spot.
-      const barrier = new Deferred();
+      const barrier = new Deferred<void>();
       let counter = 0;
 
       return integrationHelpers.withTestDb(persistence, db => {