Merge branch 'master' into ch-storage-emulator

Author: hsubox76

.changeset/chatty-cooks-drop.md

@@ -0,0 +1,5 @@
+---
+"@firebase/component": minor
+---
+
+Support new instantiation mode `EXPLICIT`

.changeset/config.json

@@ -13,23 +13,21 @@
     "firebase-namespace-integration-test",
     "firebase-firestore-integration-test",
     "firebase-messaging-integration-test",
+    "firebase-compat-typings-test",
     "@firebase/app-exp",
+    "@firebase/analytics-compat",
     "@firebase/analytics-exp",
     "@firebase/auth-exp",
     "@firebase/auth-compat",
-    "@firebase/auth-types-exp",
     "@firebase/functions-compat",
     "@firebase/functions-exp",
-    "@firebase/functions-types-exp",
     "@firebase/installations-exp",
-    "@firebase/installations-types-exp",
     "@firebase/installations-compat",
     "@firebase/messaging-exp",
-    "@firebase/messaging-types-exp",
+    "@firebase/messaging-compat",
     "@firebase/performance-exp",
-    "@firebase/performance-types-exp",
+    "@firebase/performance-compat",
     "@firebase/remote-config-exp",
-    "@firebase/remote-config-types-exp",
     "@firebase/remote-config-compat",
     "firebase-exp",
     "@firebase/app-compat",

.changeset/happy-planets-lick.md

@@ -0,0 +1,5 @@
+---
+"@firebase/rules-unit-testing": patch
+---
+
+Fix assertFails not correctly catching RTDB permission denied errors (#4667).

.changeset/stale-zebras-hug.md

@@ -0,0 +1,7 @@
+---
+"@firebase/app-types": patch
+"@firebase/app": patch
+"@firebase/rules-unit-testing": patch
+---
+
+Internal typing changes

.changeset/thick-ties-hang.md

@@ -0,0 +1,5 @@
+---
+'@firebase/rules-unit-testing': patch
+---
+
+Depend on @firebase/component directly to fix the use with Yarn Plug'n'Play

.github/CODEOWNERS

@@ -90,7 +90,6 @@ scripts/docgen/content-sources/ @firebase/firebase-techwriters @firebase/jssdk-g
 
 # Auth-Exp Code
 packages-exp/auth-exp  @avolkovi @samhorlbeck @yuchenshi @firebase/jssdk-global-approvers
-packages-exp/auth-types-exp  @avolkovi @samhorlbeck @yuchenshi @firebase/jssdk-global-approvers
 packages-exp/auth-compat-exp @avolkovi @samhorlbeck @yuchenshi @firebase/jssdk-global-approvers
 
 # Installations-Exp Code
@@ -103,5 +102,4 @@ packages/performance-types-exp  @alikn @zijianjoy @firebase/jssdk-global-approve
 
 # RC-Exp Code
 packages/remote-config-exp  @erikeldridge @firebase/jssdk-global-approvers
-packages/remote-config-types-exp  @erikeldridge @firebase/jssdk-global-approvers
 packages/remote-config-compat  @erikeldridge @firebase/jssdk-global-approvers

.github/workflows/lint.yml

@@ -1,6 +1,6 @@
 name: Lint All Packages
 
-on: push
+on: pull_request
 
 jobs:
   test:

LICENSE

@@ -1,3 +1,5 @@
+This source code is licensed under Apache-2.0 apart from the protobuf library
+which is licensed under BSD-3-Clause, both licenses given below.
 
                                  Apache License
                            Version 2.0, January 2004
@@ -200,3 +202,39 @@
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
    limitations under the License.
+
+------------------------------------------------------------------------------
+
+For Google protobuf source.
+
+file: [source code root]/packages/firestore/src/protos/google/protobuf/any.proto
+
+// Protocol Buffers - Google's data interchange format
+// Copyright 2008 Google Inc.  All rights reserved.
+// https://developers.google.com/protocol-buffers/
+//
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+//     * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+//     * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following disclaimer
+// in the documentation and/or other materials provided with the
+// distribution.
+//     * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived from
+// this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

common/api-review/analytics-exp.api.md

@@ -37,7 +37,7 @@ export type CustomEventName<T> = T extends EventNameString ? never : T;
 // @public
 export interface CustomParams {
     // (undocumented)
-    [key: string]: any;
+    [key: string]: unknown;
 }
 
 // @public
@@ -180,7 +180,7 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'add_payment_i
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'add_shipping_info', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'add_shipping_info', eventParams?: {
     coupon?: EventParams['coupon'];
     currency?: EventParams['currency'];
     items?: EventParams['items'];
@@ -190,15 +190,15 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'add_shipping_
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'add_to_cart' | 'add_to_wishlist' | 'remove_from_cart', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'add_to_cart' | 'add_to_wishlist' | 'remove_from_cart', eventParams?: {
     currency?: EventParams['currency'];
     value?: EventParams['value'];
     items?: EventParams['items'];
     [key: string]: any;
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'begin_checkout', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'begin_checkout', eventParams?: {
     currency?: EventParams['currency'];
     coupon?: EventParams['coupon'];
     value?: EventParams['value'];
@@ -207,7 +207,7 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'begin_checkou
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'checkout_progress', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'checkout_progress', eventParams?: {
     currency?: EventParams['currency'];
     coupon?: EventParams['coupon'];
     value?: EventParams['value'];
@@ -218,36 +218,36 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'checkout_prog
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'exception', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'exception', eventParams?: {
     description?: EventParams['description'];
     fatal?: EventParams['fatal'];
     [key: string]: any;
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'generate_lead', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'generate_lead', eventParams?: {
     value?: EventParams['value'];
     currency?: EventParams['currency'];
     transaction_id?: EventParams['transaction_id'];
     [key: string]: any;
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'login', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'login', eventParams?: {
     method?: EventParams['method'];
     [key: string]: any;
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'page_view', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'page_view', eventParams?: {
     page_title?: string;
     page_location?: string;
     page_path?: string;
     [key: string]: any;
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'purchase' | 'refund', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'purchase' | 'refund', eventParams?: {
     value?: EventParams['value'];
     currency?: EventParams['currency'];
     transaction_id: EventParams['transaction_id'];
@@ -260,7 +260,7 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'purchase' | '
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'screen_view', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'screen_view', eventParams?: {
     app_name: string;
     screen_name: EventParams['screen_name'];
     app_id?: string;
@@ -270,13 +270,13 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'screen_view',
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'search' | 'view_search_results', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'search' | 'view_search_results', eventParams?: {
     search_term?: EventParams['search_term'];
     [key: string]: any;
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'select_content', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'select_content', eventParams?: {
     items?: EventParams['items'];
     promotions?: EventParams['promotions'];
     content_type?: EventParams['content_type'];
@@ -285,44 +285,44 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'select_conten
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'select_item', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'select_item', eventParams?: {
     items?: EventParams['items'];
     item_list_name?: EventParams['item_list_name'];
     item_list_id?: EventParams['item_list_id'];
     [key: string]: any;
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'select_promotion' | 'view_promotion', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'select_promotion' | 'view_promotion', eventParams?: {
     items?: EventParams['items'];
     promotion_id?: EventParams['promotion_id'];
     promotion_name?: EventParams['promotion_name'];
     [key: string]: any;
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'set_checkout_option', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'set_checkout_option', eventParams?: {
     checkout_step?: EventParams['checkout_step'];
     checkout_option?: EventParams['checkout_option'];
     [key: string]: any;
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'share', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'share', eventParams?: {
     method?: EventParams['method'];
     content_type?: EventParams['content_type'];
     content_id?: EventParams['content_id'];
     [key: string]: any;
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'sign_up', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'sign_up', eventParams?: {
     method?: EventParams['method'];
     [key: string]: any;
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'timing_complete', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'timing_complete', eventParams?: {
     name: string;
     value: number;
     event_category?: string;
@@ -331,15 +331,15 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'timing_comple
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'view_cart' | 'view_item', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'view_cart' | 'view_item', eventParams?: {
     currency?: EventParams['currency'];
     items?: EventParams['items'];
     value?: EventParams['value'];
     [key: string]: any;
 }, options?: AnalyticsCallOptions): void;
 
 // @public
-export function logEvent(analyticsInstance: Analytics, eventName: 'view_item_list', eventParams: {
+export function logEvent(analyticsInstance: Analytics, eventName: 'view_item_list', eventParams?: {
     items?: EventParams['items'];
     item_list_name?: EventParams['item_list_name'];
     item_list_id?: EventParams['item_list_id'];

common/api-review/app-exp.api.md

@@ -13,7 +13,7 @@ import { Name } from '@firebase/component';
 import { Provider } from '@firebase/component';
 
 // @internal (undocumented)
-export function _addComponent(app: FirebaseApp, component: Component): void;
+export function _addComponent<T extends Name>(app: FirebaseApp, component: Component<T>): void;
 
 // @internal (undocumented)
 export function _addOrOverwriteComponent(app: FirebaseApp, component: Component): void;
@@ -102,7 +102,7 @@ export function initializeApp(options: FirebaseOptions, config?: FirebaseAppConf
 export function onLog(logCallback: LogCallback | null, options?: LogOptions): void;
 
 // @internal (undocumented)
-export function _registerComponent(component: Component): boolean;
+export function _registerComponent<T extends Name>(component: Component<T>): boolean;
 
 // @public
 export function registerVersion(libraryKeyOrName: string, version: string, variant?: string): void;