Import version from package.json in Installations and Performance

Author: mmermerkaya

packages/installations/package.json

@@ -32,8 +32,8 @@
     "mocha": "6.1.4",
     "rollup": "1.11.0",
     "rollup-plugin-commonjs": "9.3.4",
+    "rollup-plugin-json": "4.0.0",
     "rollup-plugin-node-resolve": "4.2.3",
-    "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.21.0",
     "rollup-plugin-uglify": "6.0.2",
     "sinon": "7.3.2",

packages/installations/rollup.config.js

@@ -15,8 +15,8 @@
  * limitations under the License.
  */
 
+import json from 'rollup-plugin-json';
 import typescriptPlugin from 'rollup-plugin-typescript2';
-import replace from 'rollup-plugin-replace';
 import pkg from './package.json';
 import typescript from 'typescript';
 
@@ -25,15 +25,7 @@ const deps = Object.keys({ ...pkg.peerDependencies, ...pkg.dependencies });
 /**
  * ES5 Builds
  */
-const es5BuildPlugins = [
-  typescriptPlugin({ typescript }),
-  replace({
-    delimiters: ['__', '__'],
-    values: {
-      VERSION: JSON.stringify(pkg.version)
-    }
-  })
-];
+const es5BuildPlugins = [typescriptPlugin({ typescript }), json()];
 
 const es5Builds = [
   {
@@ -59,12 +51,7 @@ const es2017BuildPlugins = [
       }
     }
   }),
-  replace({
-    delimiters: ['__', '__'],
-    values: {
-      VERSION: JSON.stringify(pkg.version)
-    }
-  })
+  json({ preferConst: true })
 ];
 
 const es2017Builds = [

packages/installations/src/declarations.d.ts

@@ -15,9 +15,11 @@
  * limitations under the License.
  */
 
+import { version } from '../../package.json';
+
 export const PENDING_TIMEOUT_MS = 10000;
 
-export const PACKAGE_VERSION = `w:${__VERSION__}`;
+export const PACKAGE_VERSION = `w:${version}`;
 export const INTERNAL_AUTH_VERSION = 'FIS_v2';
 
 export const INSTALLATIONS_API_URL =

packages/installations/src/util/constants.ts

@@ -3,6 +3,7 @@
   "compilerOptions": {
     "lib": ["es2017", "dom"],
     "downlevelIteration": true,
+    "resolveJsonModule": true,
 
     "strict": true,
     "noUnusedLocals": true,

packages/installations/tsconfig.json

@@ -40,7 +40,7 @@
     "chai": "4.2.0",
     "mocha": "6.1.4",
     "rollup": "1.11.0",
-    "rollup-plugin-replace": "2.2.0",
+    "rollup-plugin-json": "4.0.0",
     "rollup-plugin-typescript2": "0.21.0",
     "sinon": "7.3.2",
     "sinon-chai": "3.3.0",

packages/performance/declarations.d.ts

@@ -14,8 +14,8 @@
  * limitations under the License.
  */
 
+import json from 'rollup-plugin-json';
 import typescriptPlugin from 'rollup-plugin-typescript2';
-import replace from 'rollup-plugin-replace';
 import typescript from 'typescript';
 import pkg from './package.json';
 
@@ -26,17 +26,7 @@ const deps = Object.keys(
 /**
  * ES5 Builds
  */
-const es5BuildPlugins = [
-  typescriptPlugin({
-    typescript
-  }),
-  replace({
-    delimiters: ['__', '__'],
-    values: {
-      PERF_SDK_VERSION: JSON.stringify(pkg.version)
-    }
-  })
-];
+const es5BuildPlugins = [typescriptPlugin({ typescript }), json()];
 
 const es5Builds = [
   {
@@ -63,12 +53,7 @@ const es2017BuildPlugins = [
       }
     }
   }),
-  replace({
-    delimiters: ['__', '__'],
-    values: {
-      PERF_SDK_VERSION: JSON.stringify(pkg.version)
-    }
-  })
+  json({ preferConst: true })
 ];
 
 const es2017Builds = [

packages/performance/package.json

@@ -14,7 +14,9 @@
  * limitations under the License.
  */
 
-export const SDK_VERSION = __PERF_SDK_VERSION__;
+import { version } from '../package.json';
+
+export const SDK_VERSION = version;
 /** The prefix for start User Timing marks used for creating Traces. */
 export const TRACE_START_MARK_PREFIX = 'FB-PERF-TRACE-START';
 /** The prefix for stop User Timing marks used for creating Traces. */

packages/performance/rollup.config.js

@@ -25,6 +25,7 @@ import { Api, setupApi } from './api_service';
 import { SettingsService } from './settings_service';
 import { FirebaseApp } from '@firebase/app-types';
 import * as initializationService from './initialization_service';
+import { SDK_VERSION } from '../constants';
 import * as attributeUtils from '../utils/attributes_utils';
 import { createNetworkRequestEntry } from '../resources/network_request';
 import '../../test/setup';
@@ -83,7 +84,7 @@ describe('Performance Monitoring > perf_logger', () => {
       const START_TIME = 12345;
       const DURATION = 321;
       const EXPECTED_TRACE_MESSAGE = `{"application_info":{"google_app_id":"${APP_ID}",\
-"app_instance_id":"${IID}","web_app_info":{"sdk_version":"${__PERF_SDK_VERSION__}",\
+"app_instance_id":"${IID}","web_app_info":{"sdk_version":"${SDK_VERSION}",\
 "page_url":"${PAGE_URL}","service_worker_status":${SERVICE_WORKER_STATUS},\
 "visibility_state":${VISIBILITY_STATE},"effective_connection_type":${EFFECTIVE_CONNECTION_TYPE}},\
 "application_process_state":0},"trace_metric":{"name":"${TRACE_NAME}","is_auto":false,\
@@ -137,7 +138,7 @@ describe('Performance Monitoring > perf_logger', () => {
           1000
       );
       const EXPECTED_NETWORK_MESSAGE = `{"application_info":{"google_app_id":"${APP_ID}",\
-"app_instance_id":"${IID}","web_app_info":{"sdk_version":"${__PERF_SDK_VERSION__}",\
+"app_instance_id":"${IID}","web_app_info":{"sdk_version":"${SDK_VERSION}",\
 "page_url":"${PAGE_URL}","service_worker_status":${SERVICE_WORKER_STATUS},\
 "visibility_state":${VISIBILITY_STATE},"effective_connection_type":${EFFECTIVE_CONNECTION_TYPE}},\
 "application_process_state":0},\

packages/performance/src/constants.ts

@@ -2,13 +2,12 @@
   "extends": "../../config/tsconfig.base.json",
   "compilerOptions": {
     "outDir": "dist",
+    "resolveJsonModule": true,
     "strict": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noImplicitReturns": true,
     "noFallthroughCasesInSwitch": true
   },
-  "exclude": [
-    "dist/**/*"
-  ]
-}
+  "exclude": ["dist/**/*"]
+}