Pull auth from service instead of instantiating directly

Author: sam-gc

common/api-review/auth-exp.api.md

@@ -304,7 +304,7 @@ export class PhoneAuthCredential extends AuthCredential implements externs.Phone
 
 // @public (undocumented)
 export class PhoneAuthProvider implements externs.PhoneAuthProvider {
-    constructor(auth: Auth_2);
+    constructor(auth: externs.Auth);
     // (undocumented)
     static credential(verificationId: string, verificationCode: string): PhoneAuthCredential;
     // (undocumented)

packages-exp/auth-compat-exp/index.ts

@@ -43,7 +43,8 @@ function registerAuthCompat(instance: _FirebaseNamespace): void {
       container => {
         // getImmediate for FirebaseApp will always succeed
         const app = container.getProvider('app').getImmediate();
-        return new Auth(app);
+        const auth = container.getProvider('auth-exp').getImmediate();
+        return new Auth(app, auth as impl.AuthImpl);
       },
       ComponentType.PUBLIC
     )
@@ -82,4 +83,5 @@ function registerAuthCompat(instance: _FirebaseNamespace): void {
   instance.registerVersion('auth', version);
 }
 
+impl.registerAuth(_getClientPlatform());
 registerAuthCompat(firebase as _FirebaseNamespace);

packages-exp/auth-compat-exp/src/auth.ts

@@ -36,9 +36,9 @@ import {
 import { unwrap, Wrapper } from './wrap';
 
 export class Auth implements compat.FirebaseAuth, Wrapper<externs.Auth> {
-  private readonly auth: impl.AuthImpl;
+  // private readonly auth: impl.AuthImpl;
 
-  constructor(readonly app: FirebaseApp) {
+  constructor(readonly app: FirebaseApp, private readonly auth: impl.AuthImpl) {
     const { apiKey, authDomain } = app.options;
 
     // TODO(avolkovi): Implement proper persistence fallback
@@ -59,7 +59,7 @@ export class Auth implements compat.FirebaseAuth, Wrapper<externs.Auth> {
       sdkClientVersion: impl._getClientVersion(_getClientPlatform())
     };
 
-    this.auth = new impl.AuthImpl(app, config);
+    // this.auth = new impl.AuthImpl(app, config);
 
     // This promise is intended to float; auth initialization happens in the
     // background, meanwhile the auth object may be used by the app.

packages-exp/auth-exp/internal/index.ts

@@ -28,6 +28,7 @@ export { Persistence } from '../src/core/persistence';
 export { UserImpl } from '../src/core/user/user_impl';
 export { _getInstance } from '../src/core/util/instantiator';
 export { UserCredential, UserParameters } from '../src/model/user';
+export { registerAuth } from '../src/core/auth/register';
 export {
   DEFAULT_API_HOST,
   DEFAULT_API_SCHEME,