Skip to content

Commit f354f64

Browse files
committed
Used Trusted Types When API is available for gtag URL creation (#7155)
* Move changes from pr#7052 to fresh branch * Move @types/trusted-types into dev deps
1 parent 20be3b5 commit f354f64

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

packages/analytics/src/errors.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ export const enum AnalyticsError {
2828
CONFIG_FETCH_FAILED = 'config-fetch-failed',
2929
NO_API_KEY = 'no-api-key',
3030
NO_APP_ID = 'no-app-id',
31-
NO_CLIENT_ID = 'no-client-id'
31+
NO_CLIENT_ID = 'no-client-id',
32+
INVALID_GTAG_RESOURCE = 'invalid-gtag-resource'
3233
}
3334

3435
const ERRORS: ErrorMap<AnalyticsError> = {
@@ -66,7 +67,9 @@ const ERRORS: ErrorMap<AnalyticsError> = {
6667
[AnalyticsError.NO_APP_ID]:
6768
'The "appId" field is empty in the local Firebase config. Firebase Analytics requires this field to' +
6869
'contain a valid app ID.',
69-
[AnalyticsError.NO_CLIENT_ID]: 'The "client_id" field is empty.'
70+
[AnalyticsError.NO_CLIENT_ID]: 'The "client_id" field is empty.',
71+
[AnalyticsError.INVALID_GTAG_RESOURCE]:
72+
'Trusted Types detected an invalid gtag resource: {$gtagURL}.'
7073
};
7174

7275
interface ErrorParams {
@@ -79,6 +82,7 @@ interface ErrorParams {
7982
};
8083
[AnalyticsError.INVALID_ANALYTICS_CONTEXT]: { errorInfo: string };
8184
[AnalyticsError.INDEXEDDB_UNAVAILABLE]: { errorInfo: string };
85+
[AnalyticsError.INVALID_GTAG_RESOURCE]: { gtagURL: string };
8286
}
8387

8488
export const ERROR_FACTORY = new ErrorFactory<AnalyticsError, ErrorParams>(

0 commit comments

Comments
 (0)