build only packages needed for testing

Author: Feiyang1

integration/firestore/firebase_export.ts

@@ -15,8 +15,10 @@
  * limitations under the License.
  */
 
-import * as firebase from 'firebase/app';
-import 'firebase/firestore';
+import firebase from '@firebase/app';
+import '@firebase/firestore';
+import { FirebaseApp } from '@firebase/app-types';
+import { Settings, FirebaseFirestore } from '@firebase/firestore-types';
 
 // This file replaces "packages/firestore/test/integration/util/firebase_export"
 // and depends on the minified sources.
@@ -25,9 +27,9 @@ let appCount = 0;
 
 export function newTestFirestore(
   projectId: string,
-  nameOrApp?: string | firebase.app.App,
-  settings?: firebase.firestore.Settings
-): firebase.firestore.Firestore {
+  nameOrApp?: string | FirebaseApp,
+  settings?: Settings
+): FirebaseFirestore {
   if (nameOrApp === undefined) {
     nameOrApp = 'test-app-' + appCount++;
   }
@@ -36,7 +38,7 @@ export function newTestFirestore(
       ? firebase.initializeApp({ apiKey: 'fake-api-key', projectId }, nameOrApp)
       : nameOrApp;
 
-  const firestore = firebase.firestore(app);
+  const firestore = firebase.firestore!(app);
   if (settings) {
     firestore.settings(settings);
   }

integration/firestore/firebase_export_memory.ts

@@ -15,8 +15,10 @@
  * limitations under the License.
  */
 
-import * as firebase from 'firebase/app';
-import 'firebase/firestore/memory';
+import firebase from '@firebase/app';
+import '@firebase/firestore/memory';
+import { FirebaseApp } from '@firebase/app-types';
+import { Settings, FirebaseFirestore } from '@firebase/firestore-types';
 
 // This file replaces "packages/firestore/test/integration/util/firebase_export"
 // and depends on the minified sources.
@@ -25,9 +27,9 @@ let appCount = 0;
 
 export function newTestFirestore(
   projectId: string,
-  nameOrApp?: string | firebase.app.App,
-  settings?: firebase.firestore.Settings
-): firebase.firestore.Firestore {
+  nameOrApp?: string | FirebaseApp,
+  settings?: Settings
+): FirebaseFirestore {
   if (nameOrApp === undefined) {
     nameOrApp = 'test-app-' + appCount++;
   }

integration/firestore/package.json

@@ -13,11 +13,9 @@
     "test:memory": "yarn build:memory; karma start --single-run",
     "test:memory:debug": "yarn build:memory; karma start --auto-watch --browsers Chrome"
   },
-  "peerDependencies": {
-    "@firebase/app": "0.x",
-    "@firebase/firestore": "1.16.4"
-  },
   "devDependencies": {
+    "@firebase/app": "0.6.10",
+    "@firebase/firestore": "1.16.4",
     "@types/mocha": "7.0.2",
     "gulp": "4.0.2",
     "gulp-filter": "6.0.0",

packages/firestore/register-module.ts

@@ -19,7 +19,7 @@ import * as types from '@firebase/firestore-types';
 
 declare module '@firebase/app-types' {
   interface FirebaseNamespace {
-    firestore?: {
+    firestore: {
       (app?: FirebaseApp): types.FirebaseFirestore;
       Blob: typeof types.Blob;
       CollectionReference: typeof types.CollectionReference;

scripts/ci-test/build.ts

@@ -0,0 +1,54 @@
+/**
+ * @license
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { TestTask, TestReason } from './run_changed';
+import { spawn } from 'child-process-promise';
+import chalk from 'chalk';
+import { resolve } from 'path';
+const root = resolve(__dirname, '../..');
+
+export async function buildForTests(testTasks: TestTask[]) {
+  try {
+    if (testTasks.length === 0) {
+      chalk`{green No test tasks. Skipping all tests }`;
+      process.exit(0);
+    }
+
+    const lernaCmd = ['lerna', 'run'];
+    console.log(chalk`{blue Running build in:}`);
+    for (const task of testTasks) {
+      if (task.reason === TestReason.Changed) {
+        console.log(chalk`{yellow ${task.pkgName} (contains modified files)}`);
+      } else if (task.reason === TestReason.Dependent) {
+        console.log(
+          chalk`{yellow ${task.pkgName} (depends on modified files)}`
+        );
+      } else {
+        console.log(chalk`{yellow ${task.pkgName} (running all tests)}`);
+      }
+      lernaCmd.push('--scope');
+      lernaCmd.push(task.pkgName);
+    }
+
+    lernaCmd.push('--include-dependencies', 'build');
+    await spawn('npx', lernaCmd, { stdio: 'inherit', cwd: root });
+    process.exit(0);
+  } catch (e) {
+    console.error(chalk`{red ${e}}`);
+    process.exit(1);
+  }
+}

scripts/ci-test/run_changed.ts

@@ -19,15 +19,15 @@ import { resolve } from 'path';
 import { spawn, exec } from 'child-process-promise';
 import chalk from 'chalk';
 import simpleGit from 'simple-git/promise';
-const root = resolve(__dirname, '..');
+const root = resolve(__dirname, '../..');
 const git = simpleGit(root);
 
-interface TestTask {
+export interface TestTask {
   pkgName: string;
   reason: TestReason;
 }
 
-enum TestReason {
+export enum TestReason {
   Changed = 'changed',
   Dependent = 'dependent',
   Global = 'global'

scripts/ci-test/run_changed_no_firestore.ts

@@ -16,6 +16,7 @@
  */
 
 import { runTests, getTestTasks, createTestTask } from './run_changed';
+import { buildForTests } from './build';
 
 /**
  * Always run tests in these paths.
@@ -44,6 +45,8 @@ async function run() {
   // remove the ignored packages from the tasks
   testTasks = testTasks.filter(t => !ignoredPackages.includes(t.pkgName));
 
+  await buildForTests(testTasks);
+
   runTests(testTasks);
 }