Checking for UnknownDocument

Author: schmidt-sebastian

packages/firestore/src/api/database.ts

@@ -597,7 +597,11 @@ export class Transaction implements firestore.Transaction {
         } else if (doc instanceof Document) {
           return new DocumentSnapshot(this._firestore, ref._key, doc, false);
         } else {
-          throw fail('MaybeDocument is neither Document nor NoDocument');
+          throw fail(
+            `BatchGetDocumentsRequest returned unexpected document type: ${
+              doc.constructor.name
+            }`
+          );
         }
       });
   }

packages/firestore/src/local/local_documents_view.ts

@@ -168,12 +168,10 @@ export class LocalDocumentsView {
               baseDoc,
               batch.localWriteTime
             );
-            if (!mutatedDoc || mutatedDoc instanceof NoDocument) {
-              results = results.remove(key);
-            } else if (mutatedDoc instanceof Document) {
+            if (mutatedDoc instanceof Document) {
               results = results.insert(key, mutatedDoc);
             } else {
-              fail('Unknown MaybeDocument: ' + mutatedDoc);
+              results = results.remove(key);
             }
           }
         }

packages/firestore/src/model/mutation.ts

@@ -156,11 +156,7 @@ export class Precondition {
         maybeDoc.version.isEqual(this.updateTime)
       );
     } else if (this.exists !== undefined) {
-      if (this.exists) {
-        return maybeDoc instanceof Document;
-      } else {
-        return maybeDoc === null || maybeDoc instanceof NoDocument;
-      }
+      return this.exists === maybeDoc instanceof Document;
     } else {
       assert(this.isNone, 'Precondition should be empty');
       return true;