Skip to content

Commit f6b75e6

Browse files
committed
use provider.initialize in perf
1 parent 01b08aa commit f6b75e6

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

packages-exp/performance-exp/src/index.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,9 @@ export function initializePerformance(
7070
throw ERROR_FACTORY.create(ErrorCode.ALREADY_INITIALIZED);
7171
}
7272

73-
const perfInstance = provider.getImmediate() as PerformanceController;
74-
perfInstance._init(settings);
73+
const perfInstance = provider.initialize({
74+
options: settings
75+
}) as PerformanceController;
7576
return perfInstance;
7677
}
7778

@@ -89,7 +90,8 @@ export function trace(
8990
}
9091

9192
const factory: InstanceFactory<'performance-exp'> = (
92-
container: ComponentContainer
93+
container: ComponentContainer,
94+
{ options: settings }: { options?: PerformanceSettings }
9395
) => {
9496
// Dependencies
9597
const app = container.getProvider('app-exp').getImmediate();
@@ -104,7 +106,10 @@ const factory: InstanceFactory<'performance-exp'> = (
104106
throw ERROR_FACTORY.create(ErrorCode.NO_WINDOW);
105107
}
106108
setupApi(window);
107-
return new PerformanceController(app, installations);
109+
const perfInstance = new PerformanceController(app, installations);
110+
perfInstance._init(settings);
111+
112+
return perfInstance;
108113
};
109114

110115
function registerPerformance(): void {

packages/component/src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export const enum ComponentType {
3838

3939
export interface InstanceFactoryOptions {
4040
instanceIdentifier?: string;
41-
options?: Record<string, unknown>;
41+
options?: {};
4242
}
4343

4444
export type InitializeOptions = InstanceFactoryOptions;

0 commit comments

Comments
 (0)