Skip to content

Commit f6dcd42

Browse files
committed
Update API
1 parent 086d478 commit f6dcd42

File tree

3 files changed

+45
-32
lines changed

3 files changed

+45
-32
lines changed

packages/firebase/index.d.ts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8255,18 +8255,22 @@ declare namespace firebase.firestore {
82558255
*/
82568256
terminate(): Promise<void>;
82578257

8258-
loadBundle(
8259-
bundleData: ArrayBuffer | ReadableStream<ArrayBuffer> | string
8260-
): LoadBundleTask;
8261-
8262-
namedQuery(name: string): Promise<Query<DocumentData> | null>;
8263-
82648258
/**
82658259
* @hidden
82668260
*/
82678261
INTERNAL: { delete: () => Promise<void> };
82688262
}
82698263

8264+
export function loadBundle(
8265+
db: Firestore,
8266+
bundleData: ArrayBuffer | ReadableStream<ArrayBuffer> | string
8267+
): LoadBundleTask;
8268+
8269+
export function namedQuery(
8270+
db: Firestore,
8271+
name: string
8272+
): Promise<Query<DocumentData> | null>;
8273+
82708274
export interface LoadBundleTask {
82718275
onProgress(
82728276
next?: (progress: LoadBundleTaskProgress) => any,

packages/firestore-types/index.d.ts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,15 +96,19 @@ export class FirebaseFirestore {
9696

9797
terminate(): Promise<void>;
9898

99-
loadBundle(
100-
bundleData: ArrayBuffer | ReadableStream<ArrayBuffer> | string
101-
): LoadBundleTask;
102-
103-
namedQuery(name: string): Promise<Query<DocumentData> | null>;
104-
10599
INTERNAL: { delete: () => Promise<void> };
106100
}
107101

102+
export function loadBundle(
103+
db: FirebaseFirestore,
104+
bundleData: ArrayBuffer | ReadableStream<ArrayBuffer> | string
105+
): LoadBundleTask;
106+
107+
export function namedQuery(
108+
db: FirebaseFirestore,
109+
name: string
110+
): Promise<Query<DocumentData> | null>;
111+
108112
export interface LoadBundleTask {
109113
onProgress(
110114
next?: (progress: LoadBundleTaskProgress) => any,

packages/firestore/src/api/database.ts

Lines changed: 25 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -624,26 +624,6 @@ export class Firestore implements PublicFirestore, FirebaseService {
624624
}
625625
}
626626

627-
loadBundle(
628-
bundleData: ArrayBuffer | ReadableStream<Uint8Array> | string
629-
): LoadBundleTask {
630-
this.ensureClientConfigured();
631-
const resultTask = new LoadBundleTask();
632-
this._firestoreClient!.loadBundle(bundleData, resultTask);
633-
return resultTask;
634-
}
635-
636-
namedQuery(name: string): Promise<PublicQuery | null> {
637-
this.ensureClientConfigured();
638-
return this._firestoreClient!.getNamedQuery(name).then(namedQuery => {
639-
if (!namedQuery) {
640-
return null;
641-
}
642-
643-
return new Query(namedQuery.query, this, null);
644-
});
645-
}
646-
647627
ensureClientConfigured(): FirestoreClient {
648628
if (!this._firestoreClient) {
649629
// Kick off starting the client but don't actually wait for it.
@@ -808,6 +788,31 @@ export function setLogLevel(level: PublicLogLevel): void {
808788
setClientLogLevel(level);
809789
}
810790

791+
export function loadBundle(
792+
db: Firestore,
793+
bundleData: ArrayBuffer | ReadableStream<Uint8Array> | string
794+
): LoadBundleTask {
795+
const resultTask = new LoadBundleTask();
796+
db.ensureClientConfigured().loadBundle(bundleData, resultTask);
797+
return resultTask;
798+
}
799+
800+
export function namedQuery(
801+
db: Firestore,
802+
name: string
803+
): Promise<PublicQuery | null> {
804+
return db
805+
.ensureClientConfigured()
806+
.getNamedQuery(name)
807+
.then(namedQuery => {
808+
if (!namedQuery) {
809+
return null;
810+
}
811+
812+
return new Query(namedQuery.query, db, null);
813+
});
814+
}
815+
811816
/**
812817
* A reference to a transaction.
813818
*/

0 commit comments

Comments
 (0)