Cleanup

Author: hsubox76

config/.eslintrc.js

@@ -184,7 +184,7 @@ module.exports = {
         'assertionStyle': 'as'
       }
     ],
-    '@typescript-eslint/no-explicit-any': 'error',
+    '@typescript-eslint/no-explicit-any': ['error', { 'ignoreRestArgs': true }],
     '@typescript-eslint/no-namespace': [
       'error',
       {

packages/storage/.npmignore

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright 2017 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

packages/storage/compat/index.ts

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright 2019 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

packages/storage/compat/list.ts

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright 2017 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

packages/storage/compat/tasksnapshot.ts

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright 2018 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

packages/storage/rollup.config.compat.js

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright 2018 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

packages/storage/rollup.config.exp.js

@@ -50,9 +50,6 @@ export function start(
   }
   let triggeredCallback = false;
 
-  // TODO: This disable can be removed and the 'ignoreRestArgs' option added to
-  // the no-explicit-any rule when ESlint releases it.
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   function triggerCallback(...args: any[]): void {
     if (!triggeredCallback) {
       triggeredCallback = true;
@@ -67,9 +64,6 @@ export function start(
     }, millis);
   }
 
-  // TODO: This disable can be removed and the 'ignoreRestArgs' option added to
-  // the no-explicit-any rule when ESlint releases it.
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   function handler(success: boolean, ...args: any[]): void {
     if (triggeredCallback) {
       return;

packages/storage/src/implementation/backoff.ts

@@ -30,7 +30,6 @@ export function makeQueryString(params: UrlParams): string {
   let queryPart = '?';
   for (const key in params) {
     if (params.hasOwnProperty(key)) {
-      // @ts-ignore TODO: remove once typescript is upgraded to 3.5.x
       const nextPart = encode(key) + '=' + encode(params[key]);
       queryPart = queryPart + nextPart + '&';
     }

packages/storage/src/implementation/url.ts

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright 2017 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -42,13 +42,11 @@ function makeFakeService(
 }
 
 function makeStorage(url: string): ReferenceCompat {
-  console.log('makeStorage');
   const service = new StorageService(
     {} as FirebaseApp,
     testShared.emptyAuthProvider,
     testShared.makePool(null)
   );
-  console.log('created service');
   return new ReferenceCompat(new Reference(service, url));
 }
 

packages/storage/test/unit/reference.compat.test.ts

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright 2017 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

packages/storage/test/unit/reference.exp.test.ts

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright 2017 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

packages/storage/test/unit/service.compat.test.ts

@@ -1,6 +1,6 @@
 /**
  * @license
- * Copyright 2017 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

packages/storage/test/unit/service.exp.test.ts

@@ -64,7 +64,6 @@ export class TestingXhrIo implements XhrIo {
     headers?: Headers
   ): Promise<XhrIo> {
     if (this.state !== State.START) {
-      //TODO: Make a code.
       throw new FirebaseStorageError(Code.UNKNOWN, "Can't send again");
     }
 
@@ -82,7 +81,6 @@ export class TestingXhrIo implements XhrIo {
     headers: { [key: string]: string }
   ): void {
     if (this.state !== State.SENT) {
-      //TODO: Make a code.
       throw new FirebaseStorageError(
         Code.UNKNOWN,
         "Can't simulate response before send/more than once"