Review

Author: schmidt-sebastian

packages/storage/src/implementation/location.ts

@@ -93,7 +93,7 @@ export class Location {
 
     const cloudStorageHost =
       '(?:storage.googleapis.com|storage.cloud.google.com)';
-    const cloudStoragePath = '([^?]*)';
+    const cloudStoragePath = '([^?#]*)';
     const cloudStorageRegExp = new RegExp(
       `^https?://${cloudStorageHost}/${bucketDomain}/${cloudStoragePath}`,
       'i'

packages/storage/test/service.test.ts

@@ -201,6 +201,12 @@ GOOG4-RSA-SHA256`
       );
       assert.equal(ref.toString(), 'gs://mybucket/path with space/image.png');
     });
+    it('Works with storage.cloud.google.com URLs and escaped slash', () => {
+      const ref = service.refFromURL(
+        `https://storage.cloud.google.com/mybucket/path%20with%20space%2Fimage.png`
+      );
+      assert.equal(ref.toString(), 'gs://mybucket/path with space/image.png');
+    });
   });
   describe('Argument verification', () => {
     const service = new Service(