Skip to content

Commit f954b09

Browse files
More cleanup
1 parent 6321a66 commit f954b09

File tree

2 files changed

+16
-12
lines changed

2 files changed

+16
-12
lines changed

packages/database/src/core/Repo.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export class Repo {
8686
public repoInfo_: RepoInfo,
8787
forceRestClient: boolean,
8888
public app: FirebaseApp,
89-
public authTokenProvider: AuthTokenProvider
89+
authTokenProvider: AuthTokenProvider
9090
) {
9191
this.stats_ = StatsManager.getCollection(repoInfo_);
9292

packages/database/src/core/RepoManager.ts

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -91,17 +91,21 @@ export class RepoManager {
9191
* Update an existing repo in place to point to a new host/port.
9292
*/
9393
applyEmulatorSettings(repo: Repo, host: string, port: number): void {
94-
const url = `http://${host}:${port}?ns=${repo.repoInfo_.namespace}`;
95-
96-
const nodeAdmin = repo.repoInfo_.nodeAdmin;
97-
const authTokenProvider = nodeAdmin
98-
? new EmulatorAdminTokenProvider()
99-
: repo.authTokenProvider;
100-
101-
// Update the repo in-place
102-
const { repoInfo } = parseRepoInfo(url, nodeAdmin);
103-
repo.repoInfo_ = repoInfo;
104-
repo.authTokenProvider = authTokenProvider;
94+
repo.repoInfo_ = new RepoInfo(
95+
`${host}/${port}`,
96+
/* secure= */ false,
97+
repo.repoInfo_.namespace,
98+
repo.repoInfo_.webSocketOnly,
99+
repo.repoInfo_.nodeAdmin,
100+
repo.repoInfo_.persistenceKey,
101+
repo.repoInfo_.includeNamespaceInQueryParams
102+
);
103+
104+
if (repo.repoInfo_.nodeAdmin) {
105+
// TODO(samtstern): We need to re-run the initialization of the
106+
// `authTokenProvider` related code in the RepoInfo constructor
107+
repo.authTokenProvider = new EmulatorAdminTokenProvider();
108+
}
105109
}
106110

107111
/**

0 commit comments

Comments
 (0)