Descriptive errors when changing the current user.

Author: DellaBitta

packages/auth/src/core/auth/auth_impl.ts

@@ -62,7 +62,10 @@ import {
   PersistenceUserManager
 } from '../persistence/persistence_user_manager';
 import { _reloadWithoutSaving } from '../user/reload';
-import { _assert, _createError } from '../util/assert';
+import {
+  _assert,
+  _serverAppCurrentUserOperationNotSupportedError
+} from '../util/assert';
 import { _getInstance } from '../util/instantiator';
 import { _getUserLanguage } from '../util/navigator';
 import { _getClientVersion } from '../util/version';
@@ -356,7 +359,7 @@ export class AuthImpl implements AuthInternal, _FirebaseService {
   async updateCurrentUser(userExtern: User | null): Promise<void> {
     if (_isFirebaseServerApp(this.app)) {
       return Promise.reject(
-        _createError(this, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+        _serverAppCurrentUserOperationNotSupportedError(this)
       );
     }
     // The public updateCurrentUser method needs to make a copy of the user,
@@ -402,7 +405,7 @@ export class AuthImpl implements AuthInternal, _FirebaseService {
   async signOut(): Promise<void> {
     if (_isFirebaseServerApp(this.app)) {
       return Promise.reject(
-        _createError(this, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+        _serverAppCurrentUserOperationNotSupportedError(this)
       );
     }
     // Run first, to block _setRedirectUser() if any callbacks fail.
@@ -420,7 +423,7 @@ export class AuthImpl implements AuthInternal, _FirebaseService {
   setPersistence(persistence: Persistence): Promise<void> {
     if (_isFirebaseServerApp(this.app)) {
       return Promise.reject(
-        _createError(this, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+        _serverAppCurrentUserOperationNotSupportedError(this)
       );
     }
     return this.queue(async () => {

packages/auth/src/core/strategies/anonymous.ts

@@ -22,7 +22,7 @@ import { UserCredentialImpl } from '../user/user_credential_impl';
 import { _castAuth } from '../auth/auth_impl';
 import { OperationType } from '../../model/enums';
 import { _isFirebaseServerApp } from '@firebase/app';
-import { _createError } from '../../core/util/assert';
+import { _serverAppCurrentUserOperationNotSupportedError } from '../../core/util/assert';
 import { AuthErrorCode } from '../../core/errors';
 
 /**
@@ -42,7 +42,7 @@ import { AuthErrorCode } from '../../core/errors';
 export async function signInAnonymously(auth: Auth): Promise<UserCredential> {
   if (_isFirebaseServerApp(auth.app)) {
     return Promise.reject(
-      _createError(auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+      _serverAppCurrentUserOperationNotSupportedError(auth)
     );
   }
   const authInternal = _castAuth(auth);

packages/auth/src/core/strategies/credential.ts

@@ -28,7 +28,7 @@ import { _castAuth } from '../auth/auth_impl';
 import { getModularInstance } from '@firebase/util';
 import { OperationType } from '../../model/enums';
 import { _isFirebaseServerApp } from '@firebase/app';
-import { _createError } from '../../core/util/assert';
+import { _serverAppCurrentUserOperationNotSupportedError } from '../../core/util/assert';
 import { AuthErrorCode } from '../../core/errors';
 
 export async function _signInWithCredential(
@@ -38,7 +38,7 @@ export async function _signInWithCredential(
 ): Promise<UserCredential> {
   if (_isFirebaseServerApp(auth.app)) {
     return Promise.reject(
-      _createError(auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+      _serverAppCurrentUserOperationNotSupportedError(auth)
     );
   }
   const operationType = OperationType.SIGN_IN;

packages/auth/src/core/strategies/custom_token.ts

@@ -23,8 +23,7 @@ import { UserCredentialImpl } from '../user/user_credential_impl';
 import { _castAuth } from '../auth/auth_impl';
 import { OperationType } from '../../model/enums';
 import { _isFirebaseServerApp } from '@firebase/app';
-import { _createError } from '../../core/util/assert';
-import { AuthErrorCode } from '../../core/errors';
+import { _serverAppCurrentUserOperationNotSupportedError } from '../../core/util/assert';
 /**
  * Asynchronously signs in using a custom token.
  *
@@ -50,7 +49,7 @@ export async function signInWithCustomToken(
 ): Promise<UserCredential> {
   if (_isFirebaseServerApp(auth.app)) {
     return Promise.reject(
-      _createError(auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+      _serverAppCurrentUserOperationNotSupportedError(auth)
     );
   }
   const authInternal = _castAuth(auth);

packages/auth/src/core/strategies/email_and_password.ts

@@ -29,7 +29,10 @@ import { signUp, SignUpRequest } from '../../api/authentication/sign_up';
 import { MultiFactorInfoImpl } from '../../mfa/mfa_info';
 import { EmailAuthProvider } from '../providers/email';
 import { UserCredentialImpl } from '../user/user_credential_impl';
-import { _assert, _createError } from '../util/assert';
+import {
+  _assert,
+  _serverAppCurrentUserOperationNotSupportedError
+} from '../util/assert';
 import { _setActionCodeSettingsOnRequest } from './action_code_settings';
 import { signInWithCredential } from './credential';
 import { _castAuth } from '../auth/auth_impl';
@@ -273,7 +276,7 @@ export async function createUserWithEmailAndPassword(
 ): Promise<UserCredential> {
   if (_isFirebaseServerApp(auth.app)) {
     return Promise.reject(
-      _createError(auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+      _serverAppCurrentUserOperationNotSupportedError(auth)
     );
   }
   const authInternal = _castAuth(auth);
@@ -338,7 +341,7 @@ export function signInWithEmailAndPassword(
 ): Promise<UserCredential> {
   if (_isFirebaseServerApp(auth.app)) {
     return Promise.reject(
-      _createError(auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+      _serverAppCurrentUserOperationNotSupportedError(auth)
     );
   }
   return signInWithCredential(

packages/auth/src/core/strategies/email_link.ts

@@ -35,7 +35,7 @@ import { _castAuth } from '../auth/auth_impl';
 import { handleRecaptchaFlow } from '../../platform_browser/recaptcha/recaptcha_enterprise_verifier';
 import { RecaptchaActionName, RecaptchaClientType } from '../../api';
 import { _isFirebaseServerApp } from '@firebase/app';
-import { _createError } from '../../core/util/assert';
+import { _serverAppCurrentUserOperationNotSupportedError } from '../../core/util/assert';
 
 /**
  * Sends a sign-in email link to the user with the specified email.
@@ -173,7 +173,7 @@ export async function signInWithEmailLink(
 ): Promise<UserCredential> {
   if (_isFirebaseServerApp(auth.app)) {
     return Promise.reject(
-      _createError(auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+      _serverAppCurrentUserOperationNotSupportedError(auth)
     );
   }
   const authModular = getModularInstance(auth);

packages/auth/src/core/user/account_info.ts

@@ -27,8 +27,7 @@ import { _logoutIfInvalidated } from './invalidation';
 import { getModularInstance } from '@firebase/util';
 import { ProviderId } from '../../model/enums';
 import { _isFirebaseServerApp } from '@firebase/app';
-import { _createError } from '../../core/util/assert';
-import { AuthErrorCode } from '../../core/errors';
+import { _serverAppCurrentUserOperationNotSupportedError } from '../../core/util/assert';
 
 /**
  * Updates a user's profile data.
@@ -103,7 +102,7 @@ export function updateEmail(user: User, newEmail: string): Promise<void> {
   const userInternal = getModularInstance(user) as UserInternal;
   if (_isFirebaseServerApp(userInternal.auth.app)) {
     return Promise.reject(
-      _createError(userInternal.auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+      _serverAppCurrentUserOperationNotSupportedError(userInternal.auth)
     );
   }
   return updateEmailOrPassword(userInternal, newEmail, null);

packages/auth/src/core/user/reauthenticate.ts

@@ -26,7 +26,7 @@ import { _parseToken } from './id_token_result';
 import { _logoutIfInvalidated } from './invalidation';
 import { UserCredentialImpl } from './user_credential_impl';
 import { _isFirebaseServerApp } from '@firebase/app';
-import { _createError } from '../../core/util/assert';
+import { _serverAppCurrentUserOperationNotSupportedError } from '../../core/util/assert';
 
 export async function _reauthenticate(
   user: UserInternal,
@@ -36,7 +36,7 @@ export async function _reauthenticate(
   const { auth } = user;
   if (_isFirebaseServerApp(auth.app)) {
     return Promise.reject(
-      _createError(auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+      _serverAppCurrentUserOperationNotSupportedError(auth)
     );
   }
   const operationType = OperationType.REAUTHENTICATE;

packages/auth/src/core/user/user_impl.ts

@@ -32,7 +32,10 @@ import {
 } from '../../model/user';
 import { AuthErrorCode } from '../errors';
 import { PersistedBlob } from '../persistence';
-import { _assert, _createError } from '../util/assert';
+import {
+  _assert,
+  _serverAppCurrentUserOperationNotSupportedError
+} from '../util/assert';
 import { getIdTokenResult } from './id_token_result';
 import { _logoutIfInvalidated } from './invalidation';
 import { ProactiveRefresh } from './proactive_refresh';
@@ -203,7 +206,7 @@ export class UserImpl implements UserInternal {
   async delete(): Promise<void> {
     if (_isFirebaseServerApp(this.auth.app)) {
       return Promise.reject(
-        _createError(this.auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+        _serverAppCurrentUserOperationNotSupportedError(this.auth)
       );
     }
     const idToken = await this.getIdToken();

packages/auth/src/core/util/assert.ts

@@ -102,6 +102,16 @@ export function _errorWithCustomMessage(
   });
 }
 
+export function _serverAppCurrentUserOperationNotSupportedError(
+  auth: Auth
+): FirebaseError {
+  return _errorWithCustomMessage(
+    auth,
+    AuthErrorCode.OPERATION_NOT_SUPPORTED,
+    'Operations that alter the current user are not supported in conjunction with FirebaseServerApp'
+  );
+}
+
 export function _assertInstanceOf(
   auth: Auth,
   object: object,

packages/auth/src/platform_browser/strategies/phone.ts

@@ -31,7 +31,10 @@ import { ApplicationVerifierInternal } from '../../model/application_verifier';
 import { PhoneAuthCredential } from '../../core/credentials/phone';
 import { AuthErrorCode } from '../../core/errors';
 import { _assertLinkedStatus, _link } from '../../core/user/link_unlink';
-import { _assert, _createError } from '../../core/util/assert';
+import {
+  _assert,
+  _serverAppCurrentUserOperationNotSupportedError
+} from '../../core/util/assert';
 import { AuthInternal } from '../../model/auth';
 import {
   linkWithCredential,
@@ -108,7 +111,7 @@ export async function signInWithPhoneNumber(
 ): Promise<ConfirmationResult> {
   if (_isFirebaseServerApp(auth.app)) {
     return Promise.reject(
-      _createError(auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+      _serverAppCurrentUserOperationNotSupportedError(auth)
     );
   }
   const authInternal = _castAuth(auth);
@@ -174,7 +177,7 @@ export async function reauthenticateWithPhoneNumber(
   const userInternal = getModularInstance(user) as UserInternal;
   if (_isFirebaseServerApp(userInternal.auth.app)) {
     return Promise.reject(
-      _createError(userInternal.auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+      _serverAppCurrentUserOperationNotSupportedError(userInternal.auth)
     );
   }
   const verificationId = await _verifyPhoneNumber(
@@ -298,7 +301,7 @@ export async function updatePhoneNumber(
   const userInternal = getModularInstance(user) as UserInternal;
   if (_isFirebaseServerApp(userInternal.auth.app)) {
     return Promise.reject(
-      _createError(userInternal.auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+      _serverAppCurrentUserOperationNotSupportedError(userInternal.auth)
     );
   }
   await _link(userInternal, credential);

packages/auth/src/platform_browser/strategies/redirect.ts

@@ -25,7 +25,10 @@ import {
 
 import { _castAuth } from '../../core/auth/auth_impl';
 import { _assertLinkedStatus } from '../../core/user/link_unlink';
-import { _assertInstanceOf, _createError } from '../../core/util/assert';
+import {
+  _assertInstanceOf,
+  _serverAppCurrentUserOperationNotSupportedError
+} from '../../core/util/assert';
 import { _generateEventId } from '../../core/util/event_id';
 import { AuthEventType } from '../../model/popup_redirect';
 import { UserInternal } from '../../model/user';
@@ -98,7 +101,7 @@ export async function _signInWithRedirect(
 ): Promise<void | never> {
   if (_isFirebaseServerApp(auth.app)) {
     return Promise.reject(
-      _createError(auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+      _serverAppCurrentUserOperationNotSupportedError(auth)
     );
   }
   const authInternal = _castAuth(auth);
@@ -172,7 +175,7 @@ export async function _reauthenticateWithRedirect(
   _assertInstanceOf(userInternal.auth, provider, FederatedAuthProvider);
   if (_isFirebaseServerApp(userInternal.auth.app)) {
     return Promise.reject(
-      _createError(userInternal.auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+      _serverAppCurrentUserOperationNotSupportedError(userInternal.auth)
     );
   }
   // Wait for auth initialization to complete, this will process pending redirects and clear the
@@ -311,7 +314,7 @@ export async function _getRedirectResult(
 ): Promise<UserCredential | null> {
   if (_isFirebaseServerApp(auth.app)) {
     return Promise.reject(
-      _createError(auth, AuthErrorCode.OPERATION_NOT_SUPPORTED)
+      _serverAppCurrentUserOperationNotSupportedError(auth)
     );
   }
   const authInternal = _castAuth(auth);