Merge branch 'master' into mrschmidt/sharedtests

Author: schmidt-sebastian

.changeset/clean-numbers-flow.md

@@ -0,0 +1,9 @@
+---
+"@firebase/analytics": minor
+"firebase": minor
+---
+
+Issue 2393 fix - analytics module
+
+- Added a public method `isSupported` to Analytics module which returns true if current browser context supports initialization of analytics module.
+- Added runtime checks to Analytics module that validate if cookie is enabled in current browser and if current browser environment supports indexedDB functionalities. 

.changeset/config.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
-  "changelog": ["@changesets/changelog-github", { "repo": "firebase/firebase-js-sdk"}],
+  "changelog": ["../repo-scripts/changelog-generator", { "repo": "firebase/firebase-js-sdk"}],
   "commit": false,
   "linked": [],
   "access": "public",

.changeset/friendly-crews-dream.md

@@ -8,7 +8,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "devDependencies": {
-    "firebase": "7.16.0",
+    "firebase": "7.16.1",
     "@babel/core": "7.10.4",
     "@babel/preset-env": "7.10.4",
     "browserify": "16.5.1",

.changeset/gorgeous-beers-build.md

@@ -7,7 +7,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "devDependencies": {
-    "firebase": "7.16.0",
+    "firebase": "7.16.1",
     "typescript": "3.9.6"
   }
 }

.changeset/late-ladybugs-wash.md

@@ -8,7 +8,7 @@
     "test:manual": "mocha --exit"
   },
   "devDependencies": {
-    "firebase": "7.16.0",
+    "firebase": "7.16.1",
     "chai": "4.2.0",
     "chromedriver": "83.0.1",
     "express": "4.17.1",

.changeset/nice-deers-suffer.md

@@ -7,7 +7,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "devDependencies": {
-    "firebase": "7.16.0",
+    "firebase": "7.16.1",
     "@babel/core": "7.10.4",
     "@babel/preset-env": "7.10.4",
     "@types/chai": "4.2.11",

.changeset/popular-cups-melt.md

@@ -8,7 +8,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js"
   },
   "devDependencies": {
-    "firebase": "7.16.0",
+    "firebase": "7.16.1",
     "@babel/core": "7.10.4",
     "@babel/preset-env": "7.10.4",
     "chai": "4.2.0",

.changeset/rotten-owls-drive.md

@@ -48,7 +48,8 @@
     "lint": "lerna run --scope @firebase/* --scope rxfire lint",
     "size-report": "node scripts/report_binary_size.js",
     "api-report": "lerna run --scope @firebase/*-exp api-report",
-    "docgen:exp": "node scripts/exp/docgen.js"
+    "docgen:exp": "node scripts/exp/docgen.js",
+    "postinstall": "yarn --cwd repo-scripts/changelog-generator build"
   },
   "repository": {
     "type": "git",
@@ -57,7 +58,8 @@
   "workspaces": [
     "packages/*",
     "packages-exp/*",
-    "integration/*"
+    "integration/*",
+    "repo-scripts/*"
   ],
   "devDependencies": {
     "@changesets/changelog-github": "0.2.6",

.changeset/smart-cars-doubt.md

@@ -32,7 +32,11 @@ import {
   ComponentContainer
 } from '@firebase/component';
 import { ERROR_FACTORY, AnalyticsError } from './src/errors';
-
+import {
+  isIndexedDBAvailable,
+  validateIndexedDBOpenable,
+  areCookiesEnabled
+} from '@firebase/util';
 import { name, version } from './package.json';
 
 declare global {
@@ -45,6 +49,7 @@ declare global {
  * Type constant for Firebase Analytics.
  */
 const ANALYTICS_TYPE = 'analytics';
+
 export function registerAnalytics(instance: _FirebaseNamespace): void {
   instance.INTERNAL.registerComponent(
     new Component(
@@ -55,13 +60,13 @@ export function registerAnalytics(instance: _FirebaseNamespace): void {
         const installations = container
           .getProvider('installations')
           .getImmediate();
-
         return factory(app, installations);
       },
       ComponentType.PUBLIC
     ).setServiceProps({
       settings,
-      EventName
+      EventName,
+      isSupported
     })
   );
 
@@ -97,8 +102,31 @@ registerAnalytics(firebase as _FirebaseNamespace);
 declare module '@firebase/app-types' {
   interface FirebaseNamespace {
     analytics(app?: FirebaseApp): FirebaseAnalytics;
+    isSupported(): Promise<boolean>;
   }
   interface FirebaseApp {
     analytics(): FirebaseAnalytics;
   }
 }
+
+/**
+ * this is a public static method provided to users that wraps three different checks:
+ *
+ * 1. check if cookie is enabled in current browser.
+ * 2. check if IndexedDB is supported by the browser environment.
+ * 3. check if the current browser context is valid for using IndexedDB.
+ */
+async function isSupported(): Promise<boolean> {
+  if (!areCookiesEnabled()) {
+    return false;
+  }
+  if (!isIndexedDBAvailable()) {
+    return false;
+  }
+  try {
+    const isDBOpenable: boolean = await validateIndexedDBOpenable();
+    return isDBOpenable;
+  } catch (error) {
+    return false;
+  }
+}

.changeset/thick-rabbits-guess.md

@@ -56,4 +56,4 @@
     ],
     "reportDir": "./coverage/node"
   }
-}
+}

.changeset/wild-otters-fly.md

@@ -22,7 +22,10 @@ export const enum AnalyticsError {
   NO_GA_ID = 'no-ga-id',
   ALREADY_EXISTS = 'already-exists',
   ALREADY_INITIALIZED = 'already-initialized',
-  INTEROP_COMPONENT_REG_FAILED = 'interop-component-reg-failed'
+  INTEROP_COMPONENT_REG_FAILED = 'interop-component-reg-failed',
+  INDEXED_DB_UNSUPPORTED = 'indexedDB-unsupported',
+  INVALID_INDEXED_DB_CONTEXT = 'invalid-indexedDB-context',
+  COOKIES_NOT_ENABLED = 'cookies-not-enabled'
 }
 
 const ERRORS: ErrorMap<AnalyticsError> = {
@@ -39,12 +42,21 @@ const ERRORS: ErrorMap<AnalyticsError> = {
     'settings() must be called before initializing any Analytics instance' +
     'or it will have no effect.',
   [AnalyticsError.INTEROP_COMPONENT_REG_FAILED]:
-    'Firebase Analytics Interop Component failed to instantiate'
+    'Firebase Analytics Interop Component failed to instantiate',
+  [AnalyticsError.INDEXED_DB_UNSUPPORTED]:
+    'IndexedDB is not supported by current browswer',
+  [AnalyticsError.INVALID_INDEXED_DB_CONTEXT]:
+    "Environment doesn't support IndexedDB: {$errorInfo}. " +
+    'Wrap initialization of analytics in analytics.isSupported() ' +
+    'to prevent initialization in unsupported environments',
+  [AnalyticsError.COOKIES_NOT_ENABLED]:
+    'Cookies are not enabled in this browser environment. Analytics requires cookies to be enabled.'
 };
 
 interface ErrorParams {
   [AnalyticsError.ALREADY_EXISTS]: { id: string };
   [AnalyticsError.INTEROP_COMPONENT_REG_FAILED]: { reason: Error };
+  [AnalyticsError.INVALID_INDEXED_DB_CONTEXT]: { errorInfo: string };
 }
 
 export const ERROR_FACTORY = new ErrorFactory<AnalyticsError, ErrorParams>(

integration/browserify/package.json

@@ -38,6 +38,11 @@ import { ANALYTICS_ID_FIELD } from './constants';
 import { AnalyticsError, ERROR_FACTORY } from './errors';
 import { FirebaseApp } from '@firebase/app-types';
 import { FirebaseInstallations } from '@firebase/installations-types';
+import {
+  isIndexedDBAvailable,
+  validateIndexedDBOpenable,
+  areCookiesEnabled
+} from '@firebase/util';
 
 /**
  * Maps gaId to FID fetch promises.
@@ -117,6 +122,19 @@ export function factory(
   app: FirebaseApp,
   installations: FirebaseInstallations
 ): FirebaseAnalytics {
+  if (!areCookiesEnabled()) {
+    throw ERROR_FACTORY.create(AnalyticsError.COOKIES_NOT_ENABLED);
+  }
+  if (!isIndexedDBAvailable()) {
+    throw ERROR_FACTORY.create(AnalyticsError.INDEXED_DB_UNSUPPORTED);
+  }
+  // Async but non-blocking.
+  validateIndexedDBOpenable().catch(error => {
+    throw ERROR_FACTORY.create(AnalyticsError.INVALID_INDEXED_DB_CONTEXT, {
+      errorInfo: error
+    });
+  });
+
   const analyticsId = app.options[ANALYTICS_ID_FIELD];
   if (!analyticsId) {
     throw ERROR_FACTORY.create(AnalyticsError.NO_GA_ID);

integration/firebase-typings/package.json

@@ -32,7 +32,6 @@ import {
 } from './constants';
 import { FirebaseInstallations } from '@firebase/installations-types';
 import { logger } from './logger';
-
 /**
  * Initialize the analytics instance in gtag.js by calling config command with fid.
  *

integration/messaging/package.json

@@ -1,8 +1,13 @@
 # @firebase/auth
 
-## 0.14.8
+## 0.14.9
+
 ### Patch Changes
 
+- [`b6145466`](https://github.com/firebase/firebase-js-sdk/commit/b6145466835e22495b94d2bcfc45813e81496085) [#3401](https://github.com/firebase/firebase-js-sdk/pull/3401) Thanks [@Feiyang1](https://github.com/Feiyang1)! - Add browser field in package.json
 
+## 0.14.8
+
+### Patch Changes
 
 - [`a754645e`](https://github.com/firebase/firebase-js-sdk/commit/a754645ec2be1b8c205f25f510196eee298b0d6e) [#3297](https://github.com/firebase/firebase-js-sdk/pull/3297) Thanks [@renovate](https://github.com/apps/renovate)! - Update dependency typescript to v3.9.5

integration/typescript/package.json

@@ -1,7 +1,8 @@
 {
   "name": "@firebase/auth",
-  "version": "0.14.8",
+  "version": "0.14.9",
   "main": "dist/auth.js",
+  "browser": "dist/auth.js",
   "module": "dist/auth.esm.js",
   "description": "Javascript library for Firebase Auth SDK",
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",

integration/webpack/package.json

@@ -1,5 +1,13 @@
 # Unreleased
 
+## 0.6.8
+
+### Patch Changes
+
+- [`c2b737b2`](https://github.com/firebase/firebase-js-sdk/commit/c2b737b2187cb525af4d926ca477102db7835420) [#3228](https://github.com/firebase/firebase-js-sdk/pull/3228) Thanks [@schmidt-sebastian](https://github.com/schmidt-sebastian)! - [fix] Instead of using production auth, the SDK will use test credentials
+  to connect to the Emulator when the RTDB SDK is used via the Firebase
+  Admin SDK.
+
 ## 0.6.7
 
 ### Patch Changes

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@firebase/database",
-  "version": "0.6.7",
+  "version": "0.6.8",
   "description": "",
   "author": "Firebase <[email protected]> (https://firebase.google.com/)",
   "main": "dist/index.node.cjs.js",

packages/analytics/index.ts

@@ -24,10 +24,17 @@ import { Provider } from '@firebase/component';
 import { log, warn } from './util/util';
 import { FirebaseApp } from '@firebase/app-types';
 
+export interface AuthTokenProvider {
+  getToken(forceRefresh: boolean): Promise<FirebaseAuthTokenData>;
+  addTokenChangeListener(listener: (token: string | null) => void): void;
+  removeTokenChangeListener(listener: (token: string | null) => void): void;
+  notifyForInvalidToken(): void;
+}
+
 /**
  * Abstraction around FirebaseApp's token fetching capabilities.
  */
-export class AuthTokenProvider {
+export class FirebaseAuthTokenProvider implements AuthTokenProvider {
   private auth_: FirebaseAuthInternal | null = null;
   constructor(
     private app_: FirebaseApp,
@@ -60,7 +67,7 @@ export class AuthTokenProvider {
     });
   }
 
-  addTokenChangeListener(listener: (token: string | null) => void) {
+  addTokenChangeListener(listener: (token: string | null) => void): void {
     // TODO: We might want to wrap the listener and call it with no args to
     // avoid a leaky abstraction, but that makes removing the listener harder.
     if (this.auth_) {
@@ -73,13 +80,13 @@ export class AuthTokenProvider {
     }
   }
 
-  removeTokenChangeListener(listener: (token: string | null) => void) {
+  removeTokenChangeListener(listener: (token: string | null) => void): void {
     this.authProvider_
       .get()
       .then(auth => auth.removeAuthTokenListener(listener));
   }
 
-  notifyForInvalidToken() {
+  notifyForInvalidToken(): void {
     let errorMessage =
       'Provided authentication credentials for the app named "' +
       this.app_.name +
@@ -104,3 +111,24 @@ export class AuthTokenProvider {
     warn(errorMessage);
   }
 }
+
+/* Auth token provider that the Admin SDK uses to connect to the Emulator. */
+export class EmulatorAdminTokenProvider implements AuthTokenProvider {
+  private static EMULATOR_AUTH_TOKEN = 'owner';
+
+  getToken(forceRefresh: boolean): Promise<FirebaseAuthTokenData> {
+    return Promise.resolve({
+      accessToken: EmulatorAdminTokenProvider.EMULATOR_AUTH_TOKEN
+    });
+  }
+
+  addTokenChangeListener(listener: (token: string | null) => void): void {
+    // Invoke the listener immediately to match the behavior in Firebase Auth
+    // (see packages/auth/src/auth.js#L1807)
+    listener(EmulatorAdminTokenProvider.EMULATOR_AUTH_TOKEN);
+  }
+
+  removeTokenChangeListener(listener: (token: string | null) => void): void {}
+
+  notifyForInvalidToken(): void {}
+}