PR feedback

Author: avolkovi

packages-exp/auth-exp/demo/rollup.config.js

@@ -51,7 +51,6 @@ const es5Builds = [
           lib: [
             // TODO: remove this
             "dom",
-            "es5",
             "es6",
             "webworker"
           ]

packages-exp/auth-exp/demo/src/worker/index.ts

@@ -45,7 +45,7 @@ const auth = initializeAuth(app, {
  *     available. Otherwise, the promise resolves with null.
  */
 function getIdToken(): Promise<string | null> {
-  return new Promise((resolve, _reject) => {
+  return new Promise((resolve) => {
     auth.onAuthStateChanged((user: User | null) => {
       if (user) {
         user.getIdToken().then(resolve).catch(
@@ -160,7 +160,7 @@ async function runWorkerTests(_googleIdToken: OAuthCredential): Promise<void> {
 self.onmessage = (e: MessageEvent) => {
   // https://github.com/microsoft/TypeScript/issues/12657
   const ctx = self as DedicatedWorkerGlobalScope;
-  if (e.data && e.data.type) {
+  if (e?.data.type) {
     switch (e.data.type) {
       case 'GET_USER_INFO':
         getIdToken()

packages-exp/auth-exp/index.ts

@@ -18,80 +18,20 @@
 import * as externs from '@firebase/auth-types-exp';
 import { CompleteFn, ErrorFn, Unsubscribe } from '@firebase/util';
 
-// core/auth
-export { initializeAuth } from './src/core/auth/auth_impl';
+// Core functionality shared by all browser based clients
+export * from './index.webworker';
 
-// Non-optional auth methods.
-export function setPersistence(
-  auth: externs.Auth,
-  persistence: externs.Persistence
-): void {
-  auth.setPersistence(persistence);
-}
-export function onIdTokenChanged(
-  auth: externs.Auth,
-  nextOrObserver: externs.NextOrObserver<externs.User>,
-  error?: ErrorFn,
-  completed?: CompleteFn
-): Unsubscribe {
-  return auth.onIdTokenChanged(nextOrObserver, error, completed);
-}
-export function onAuthStateChanged(
-  auth: externs.Auth,
-  nextOrObserver: externs.NextOrObserver<externs.User>,
-  error?: ErrorFn,
-  completed?: CompleteFn
-): Unsubscribe {
-  return auth.onAuthStateChanged(nextOrObserver, error, completed);
-}
-export function useDeviceLanguage(auth: externs.Auth): void {
-  auth.useDeviceLanguage();
-}
-export function signOut(auth: externs.Auth): Promise<void> {
-  return auth.signOut();
-}
+// Additional DOM dependend functionality 
 
 // core/persistence
 export {
   browserLocalPersistence,
   browserSessionPersistence
 } from './src/core/persistence/browser';
-export { inMemoryPersistence } from './src/core/persistence/in_memory';
 export { indexedDBLocalPersistence } from './src/core/persistence/indexed_db';
 export { getReactNativePersistence } from './src/core/persistence/react_native';
 
-// core/providers
-export { EmailAuthProvider } from './src/core/providers/email';
-export { OAuthProvider } from './src/core/providers/oauth';
-export { PhoneAuthProvider } from './src/core/providers/phone';
-
 // core/strategies
-export { signInAnonymously } from './src/core/strategies/anonymous';
-export {
-  signInWithCredential,
-  linkWithCredential,
-  reauthenticateWithCredential
-} from './src/core/strategies/credential';
-export { signInWithCustomToken } from './src/core/strategies/custom_token';
-export {
-  sendPasswordResetEmail,
-  confirmPasswordReset,
-  applyActionCode,
-  checkActionCode,
-  verifyPasswordResetCode,
-  createUserWithEmailAndPassword,
-  signInWithEmailAndPassword
-} from './src/core/strategies/email_and_password';
-export {
-  sendSignInLinkToEmail,
-  isSignInWithEmailLink,
-  signInWithEmailLink
-} from './src/core/strategies/email_link';
-export {
-  fetchSignInMethodsForEmail,
-  sendEmailVerification,
-  verifyBeforeUpdateEmail
-} from './src/core/strategies/email';
 export {
   signInWithPhoneNumber,
   linkWithPhoneNumber,
@@ -103,29 +43,6 @@ export {
   reauthenticateWithPopup
 } from './src/core/strategies/popup';
 
-// core
-export { ActionCodeURL, parseActionCodeURL } from './src/core/action_code_url';
-
-// core/user
-export {
-  updateProfile,
-  updateEmail,
-  updatePassword
-} from './src/core/user/account_info';
-export { getIdToken, getIdTokenResult } from './src/core/user/id_token_result';
-export { unlink } from './src/core/user/link_unlink';
-
+// platform_browser
 export { RecaptchaVerifier } from './src/platform_browser/recaptcha/recaptcha_verifier';
-
-// Non-optional user methods.
-export { reload } from './src/core/user/reload';
-export async function deleteUser(user: externs.User): Promise<void> {
-  return user.delete();
-}
-
-// MFA
-export { PhoneMultiFactorGenerator } from './src/mfa/assertions/phone';
-export { getMultiFactorResolver } from './src/mfa/mfa_resolver';
-export { multiFactor } from './src/mfa/mfa_user';
-
 export { browserPopupRedirectResolver } from './src/platform_browser/popup_redirect';

packages-exp/auth-exp/rollup.config.js

@@ -74,7 +74,6 @@ const es5Builds = [
             lib: [
               // Remove dom after we figure out why navigator stuff doesn't exist
               "dom", 
-              "es5",
               "es6",
               "webworker"
             ]