Skip to content

Commit fd3a86c

Browse files
committed
no firestore
1 parent d16070f commit fd3a86c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/test-changed-firestore.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,12 @@ jobs:
5050
id: set-output
5151
run: echo "CHANGED=true" >> "$GITHUB_OUTPUT";
5252
- name: Archive build
53-
if: ${{ !cancelled() && steps.check-changed.outcome != 'success' }}
53+
if: ${{ !cancelled() && steps.build.outcome == 'success' && steps.check-changed.outcome != 'success' }}
5454
run: |
5555
tar -cf build.tar --exclude=.git .
5656
gzip build.tar
5757
- name: Upload build archive
58-
if: ${{ !cancelled() && steps.check-changed.outcome != 'success' }}
58+
if: ${{ !cancelled() && steps.build.outcome == 'success' && steps.check-changed.outcome != 'success' }}
5959
uses: actions/upload-artifact@v3
6060
with:
6161
name: build.tar.gz

packages/firestore/src/api/database.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ export class Firestore extends LiteFirestore {
121121
// usage throws an exception.
122122
configureFirestore(this);
123123
}
124-
return null;
124+
return this._firestoreClient!.terminate();
125125
}
126126
}
127127

0 commit comments

Comments
 (0)