Skip to content

Commit fe37ed8

Browse files
committed
Remove innerHTML call
1 parent 06dc136 commit fe37ed8

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

packages/database/src/realtime/BrowserPollConnection.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,11 @@ export class FirebaseIFrameScriptHolder {
548548
//We have to actually remove all of the html inside this iframe before removing it from the
549549
//window, or IE will continue loading and executing the script tags we've already added, which
550550
//can lead to some errors being thrown. Setting innerHTML seems to be the easiest way to do this.
551-
this.myIFrame.doc.body.innerHTML = '';
551+
// TODO() ^ see if there is another way to clear the iframe contents;; can also look at the closure function
552+
// look at analytics function that removes the script tag
553+
// make sure it can't be just removed entirely
554+
// this.myIFrame.doc.body.innerHTML = '';
555+
this.myIFrame.doc.write('');
552556
setTimeout(() => {
553557
if (this.myIFrame !== null) {
554558
document.body.removeChild(this.myIFrame);

0 commit comments

Comments
 (0)