Skip to content

Support BrowserPlatforms with no window or document #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2018
Merged

Support BrowserPlatforms with no window or document #1140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/firestore/src/platform_browser/browser_platform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,18 @@ export class BrowserPlatform implements Platform {

readonly emptyByteString = '';

readonly document = document;

readonly window = window;

constructor() {
this.base64Available = typeof atob !== 'undefined';
}

get document(): Document | null {
return typeof document !== 'undefined' ? document : null;
}

get window(): Window | null {
return typeof window !== 'undefined' ? window : null;
}

loadConnection(databaseInfo: DatabaseInfo): Promise<Connection> {
return Promise.resolve(new WebChannelConnection(databaseInfo));
}
Expand Down