-
Notifications
You must be signed in to change notification settings - Fork 944
Support toc generation in the api-documenter #4931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fd9d014
make toc generation part of the api-documenter
Feiyang1 bda6d05
add instruction for generating toc
Feiyang1 c600576
generate toc only for classes and interfaces
Feiyang1 43f8605
add jssdk flag
Feiyang1 0a1b29e
update description of the command
Feiyang1 679fa99
change parameter name to --host-path
Feiyang1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
/** | ||
* @license | ||
* Copyright 2021 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { | ||
CommandLineFlagParameter, | ||
CommandLineStringParameter | ||
} from '@rushstack/ts-command-line'; | ||
import { ApiDocumenterCommandLine } from './ApiDocumenterCommandLine'; | ||
import { BaseAction } from './BaseAction'; | ||
import { generateToc } from '../toc'; | ||
|
||
export class TocAction extends BaseAction { | ||
private _g3PathParameter!: CommandLineStringParameter; | ||
private _jsSDKParameter!: CommandLineFlagParameter; | ||
public constructor(parser: ApiDocumenterCommandLine) { | ||
super({ | ||
actionName: 'toc', | ||
summary: 'Generate TOC(table of content) for Firebase devsite.', | ||
documentation: 'Generate TOC(table of content) for Firebase devsite.' | ||
}); | ||
} | ||
|
||
protected onDefineParameters(): void { | ||
super.onDefineParameters(); | ||
|
||
this._g3PathParameter = this.defineStringParameter({ | ||
parameterLongName: '--host-path', | ||
parameterShortName: '-p', | ||
argumentName: 'HOSTPATH', | ||
description: `Specifies the path where the reference docs resides (e.g. g3). | ||
Used to generate paths in the toc` | ||
}); | ||
|
||
this._jsSDKParameter = this.defineFlagParameter({ | ||
parameterLongName: '--js-sdk', | ||
parameterShortName: '-j', | ||
description: | ||
`Generating toc for the Firebase JS SDK.` + | ||
`It will create an artificial top level toc item "firebase".` | ||
}); | ||
} | ||
|
||
protected async onExecute(): Promise<void> { | ||
// override | ||
const { apiModel, outputFolder, addFileNameSuffix } = this.buildApiModel(); | ||
const g3Path: string | undefined = this._g3PathParameter.value; | ||
const jsSdk: boolean = this._jsSDKParameter.value; | ||
|
||
if (!g3Path) { | ||
throw new Error( | ||
'--g3-path is a required to generate toc, but it is not provided' | ||
); | ||
} | ||
|
||
generateToc({ | ||
apiModel, | ||
outputFolder, | ||
addFileNameSuffix, | ||
g3Path, | ||
jsSdk | ||
}); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
/** | ||
* @license | ||
* Copyright 2021 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import yaml from 'js-yaml'; | ||
import { ApiItem, ApiItemKind, ApiModel } from 'api-extractor-model-me'; | ||
import { getFilenameForApiItem } from './documenters/MarkdownDocumenterHelpers'; | ||
import { ModuleSource } from '@microsoft/tsdoc/lib-commonjs/beta/DeclarationReference'; | ||
import { writeFileSync } from 'fs'; | ||
import { resolve } from 'path'; | ||
|
||
export interface ITocGenerationOptions { | ||
apiModel: ApiModel; | ||
g3Path: string; | ||
outputFolder: string; | ||
addFileNameSuffix: boolean; | ||
jsSdk: boolean; | ||
} | ||
|
||
interface ITocItem { | ||
title: string; | ||
path: string; | ||
section?: ITocItem[]; | ||
} | ||
|
||
export function generateToc({ | ||
apiModel, | ||
g3Path, | ||
outputFolder, | ||
addFileNameSuffix, | ||
jsSdk | ||
}: ITocGenerationOptions) { | ||
const toc = []; | ||
|
||
if (jsSdk) { | ||
const firebaseToc: ITocItem = { | ||
title: 'firebase', | ||
path: `${g3Path}/index`, | ||
section: [] | ||
}; | ||
toc.push(firebaseToc); | ||
} | ||
|
||
generateTocRecursively(apiModel, g3Path, addFileNameSuffix, toc); | ||
|
||
writeFileSync( | ||
resolve(outputFolder, 'toc.yaml'), | ||
yaml.dump( | ||
{ toc }, | ||
{ | ||
quotingType: '"' | ||
} | ||
) | ||
); | ||
} | ||
|
||
function generateTocRecursively( | ||
apiItem: ApiItem, | ||
g3Path: string, | ||
addFileNameSuffix: boolean, | ||
toc: ITocItem[] | ||
) { | ||
if (apiItem.kind === ApiItemKind.EntryPoint) { | ||
// Entry point | ||
const entryPointName = (apiItem.canonicalReference | ||
.source! as ModuleSource).escapedPath.replace('@firebase/', ''); | ||
const entryPointToc: ITocItem = { | ||
title: entryPointName, | ||
path: `${g3Path}/${getFilenameForApiItem(apiItem, addFileNameSuffix)}`, | ||
section: [] | ||
}; | ||
|
||
for (const member of apiItem.members) { | ||
// only classes and interfaces have dedicated pages | ||
if ( | ||
member.kind === ApiItemKind.Class || | ||
member.kind === ApiItemKind.Interface | ||
) { | ||
const fileName = getFilenameForApiItem(member, addFileNameSuffix); | ||
entryPointToc.section!.push({ | ||
title: member.displayName, | ||
path: `${g3Path}/${fileName}` | ||
}); | ||
} | ||
} | ||
|
||
toc.push(entryPointToc); | ||
} else { | ||
// travel the api tree to find the next entry point | ||
for (const member of apiItem.members) { | ||
generateTocRecursively(member, g3Path, addFileNameSuffix, toc); | ||
} | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.