Skip to content

Update dependency yargs to v17 #5415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"@types/sinon": "9.0.10",
"@types/sinon-chai": "3.2.5",
"@types/tmp": "0.2.0",
"@types/yargs": "16.0.0",
"@types/yargs": "17.0.2",
"@types/js-yaml": "4.0.0",
"@typescript-eslint/eslint-plugin": "4.28.0",
"@typescript-eslint/eslint-plugin-tslint": "4.28.0",
Expand Down Expand Up @@ -152,7 +152,7 @@
"typescript": "4.2.2",
"watch": "1.0.2",
"webpack": "4.46.0",
"yargs": "16.2.0"
"yargs": "17.1.1"
},
"husky": {
"hooks": {
Expand Down
2 changes: 1 addition & 1 deletion packages/auth-compat/scripts/run_node_tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const argv = yargs.options({
webdriver: {
type: 'boolean'
}
}).argv;
}).parseSync();

const nyc = resolve(__dirname, '../../../node_modules/.bin/nyc');
const mocha = resolve(__dirname, '../../../node_modules/.bin/mocha');
Expand Down
2 changes: 1 addition & 1 deletion packages/auth/scripts/run_node_tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const argv = yargs.options({
webdriver: {
type: 'boolean'
}
}).argv;
}).parseSync();

const nyc = resolve(__dirname, '../../../node_modules/.bin/nyc');
const mocha = resolve(__dirname, '../../../node_modules/.bin/mocha');
Expand Down
2 changes: 1 addition & 1 deletion packages/firestore/scripts/build-bundle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const argv = yargs.options({
demandOption: true,
desc: 'The location for the transpiled JavaScript bundle'
}
}).argv;
}).parseSync();

/**
* Builds an ESM bundle for the Typescript file at `index` and writes it the
Expand Down
2 changes: 1 addition & 1 deletion packages/firestore/scripts/run-tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const argv = yargs.options({
persistence: {
type: 'boolean'
}
}).argv;
}).parseSync();

const nyc = resolve(__dirname, '../../../node_modules/.bin/nyc');
const mocha = resolve(__dirname, '../../../node_modules/.bin/mocha');
Expand Down
2 changes: 1 addition & 1 deletion repo-scripts/prune-dts/extract-public-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ const argv = yargs.options({
'includes the public APIs',
require: true
}
}).argv;
}).parseSync();

void generateApi(
argv.package,
Expand Down
2 changes: 1 addition & 1 deletion repo-scripts/prune-dts/prune-dts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ const argv = yargs.options({
type: 'string',
desc: 'The location for the index.d.ts file'
}
}).argv;
}).parseSync();

if (argv.input && argv.output) {
console.log('Removing private exports...');
Expand Down
2 changes: 1 addition & 1 deletion repo-scripts/size-analysis/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"tmp": "0.2.1",
"typescript": "4.2.2",
"terser": "5.7.0",
"yargs": "16.2.0",
"yargs": "17.1.1",
"@firebase/util": "1.3.0",
"gzip-size": "6.0.0",
"glob": "7.1.6"
Expand Down
2 changes: 1 addition & 1 deletion scripts/build/create-overloads.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const argv = yargs
};
});
})
.help().argv;
.help().parseSync();

interface Options {
input: string;
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci-test/build_changed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const argv = yargs.options({
type: 'boolean',
desc: 'if true, build all packages. Used in Test Auth workflow because Auth tests depends on the firebase package'
}
}).argv;
}).parseSync();

const allTestConfigNames = Object.keys(testConfig);
const inputTestConfigName = argv._[0].toString();
Expand Down
3 changes: 2 additions & 1 deletion scripts/ci-test/test_changed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,11 @@ import { resolve } from 'path';
import { spawn } from 'child-process-promise';
import { TestReason, filterTasks, getTestTasks, logTasks } from './tasks';
import chalk from 'chalk';
import { argv } from 'yargs';
import * as yargs from 'yargs';
import { TestConfig, testConfig } from './testConfig';
const root = resolve(__dirname, '../..');

const argv = yargs.parseSync();
const inputTestConfigName = argv._[0].toString();
const testCommand = 'test:ci';

Expand Down
2 changes: 1 addition & 1 deletion scripts/extract-deps/extract-deps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const argv = yargs.options({
demandOption: true,
desc: 'The location to write the JSON output to'
}
}).argv;
}).parseSync();

async function buildJson(
publicApi: MemberList,
Expand Down
3 changes: 2 additions & 1 deletion scripts/update-internal-dep-versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@

import { projectRoot } from './utils';
import { mapPkgNameToPkgJson } from './release/utils/workspace';
import { argv } from 'yargs';
import * as yargs from 'yargs';
import fs from 'mz/fs';

const argv = yargs.parseSync();
async function updateField(pkg: any, fieldName: string) {
const field = pkg[fieldName];
for (const depName in field) {
Expand Down
21 changes: 17 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3116,10 +3116,10 @@
resolved "https://registry.npmjs.org/@types/yargs-parser/-/yargs-parser-20.2.0.tgz#dd3e6699ba3237f0348cd085e4698780204842f9"
integrity sha512-37RSHht+gzzgYeobbG+KWryeAW8J33Nhr69cjTqSYymXVZEN9NbRYWoYlRtDhHKPVT1FyNKwaTPC1NynKZpzRA==

"@types/yargs@16.0.0":
version "16.0.0"
resolved "https://registry.npmjs.org/@types/yargs/-/yargs-16.0.0.tgz#0e033b23452da5d61b6c44747612cb80ac528751"
integrity sha512-2nN6AGeMwe8+O6nO9ytQfbMQOJy65oi1yK2y/9oReR08DaXSGtMsrLyCM1ooKqfICpCx4oITaR4LkOmdzz41Ww==
"@types/yargs@17.0.2":
version "17.0.2"
resolved "https://registry.npmjs.org/@types/yargs/-/yargs-17.0.2.tgz#8fb2e0f4cdc7ab2a1a570106e56533f31225b584"
integrity sha512-JhZ+pNdKMfB0rXauaDlrIvm+U7V4m03PPOSVoPS66z8gf+G4Z/UW8UlrVIj2MRQOBzuoEvYtjS0bqYwnpZaS9Q==
dependencies:
"@types/yargs-parser" "*"

Expand Down Expand Up @@ -16886,6 +16886,19 @@ [email protected], yargs@^16.0.3, yargs@^16.1.1, yargs@^16.2.0:
y18n "^5.0.5"
yargs-parser "^20.2.2"

[email protected]:
version "17.1.1"
resolved "https://registry.npmjs.org/yargs/-/yargs-17.1.1.tgz#c2a8091564bdb196f7c0a67c1d12e5b85b8067ba"
integrity sha512-c2k48R0PwKIqKhPMWjeiF6y2xY/gPMUlro0sgxqXpbOIohWiLNXWslsootttv7E1e73QPAMQSg5FeySbVcpsPQ==
dependencies:
cliui "^7.0.2"
escalade "^3.1.1"
get-caller-file "^2.0.5"
require-directory "^2.1.1"
string-width "^4.2.0"
y18n "^5.0.5"
yargs-parser "^20.2.2"

yargs@^15.0.2, yargs@^15.1.0:
version "15.4.1"
resolved "https://registry.npmjs.org/yargs/-/yargs-15.4.1.tgz#0d87a16de01aee9d8bec2bfbf74f67851730f4f8"
Expand Down