Adding support for ${param:FOO} syntax (#2810)

* Adding support for ${param:FOO} syntax

* add changelog

Co-authored-by: Bryan Kendall <[email protected]>

Author: joehan

CHANGELOG.md

@@ -1 +1,2 @@
+- Fixes an issue where the `${param:FOO}` syntax for Firebase Extensions did not work with the emulator.
 - Fixes issue in `database:settings:get` where the value wasn't being properly displayed.

src/extensions/emulator/optionsHelper.ts

@@ -1,7 +1,7 @@
 import * as fs from "fs-extra";
 import * as _ from "lodash";
 import * as path from "path";
-import * as paramHelper from "./paramHelper";
+import * as paramHelper from "../paramHelper";
 import * as specHelper from "./specHelper";
 import * as triggerHelper from "./triggerHelper";
 import { Resource } from "../extensionsApi";

src/extensions/emulator/paramHelper.ts

@@ -6,7 +6,7 @@ import * as fs from "fs-extra";
 import { fileExistsSync } from "../../fsutils";
 import { ExtensionSpec, Resource } from "../extensionsApi";
 import { FirebaseError } from "../../error";
-import { substituteParams } from "./paramHelper";
+import { substituteParams } from "../extensionsHelper";
 import { EmulatorLogger } from "../../emulator/emulatorLogger";
 import { Emulators } from "../../emulator/types";
 

src/extensions/emulator/specHelper.ts

@@ -78,7 +78,7 @@ export async function getFirebaseProjectParams(projectId: string): Promise<any>
 
 /**
  * This function substitutes params used in the extension spec with values.
- * (e.g If the original object contains `path/${FOO}` and the param FOO has the value of "bar",
+ * (e.g If the original object contains `path/${FOO}` or `path/${param:FOO}` and the param FOO has the value of "bar",
  * then it will become `path/bar`)
  * @param original Object containing strings that have placeholders that look like`${}`
  * @param params params to substitute the placeholders for

src/extensions/extensionsHelper.ts

@@ -126,3 +126,14 @@ export async function promptForNewParams(
   }
   return currentParams;
 }
+
+export function readParamsFile(envFilePath: string): any {
+  try {
+    const buf = fs.readFileSync(path.resolve(envFilePath), "utf8");
+    return dotenv.parse(buf.toString().trim(), { debug: true });
+  } catch (err) {
+    throw new FirebaseError(`Error reading --test-params file: ${err.message}\n`, {
+      original: err,
+    });
+  }
+}