Fixes error tracking for function deployments (#3160)

joehan · web-flow · commit fcaf12141042 · 2021-02-22T10:56:44.000-08:00
diff --git a/src/functionsDeployHelper.ts b/src/functionsDeployHelper.ts
@@ -184,8 +184,8 @@ export function logAndTrackDeployStats(queue: Queue<any, any>, errorHandler: Err
   logger.debug(`${errorHandler.errors.length} Functions Errored`);
   logger.debug(`Average Function Deployment time: ${stats.avg}`);
   if (stats.total > 0) {
-    track("Functions Deploy (Result)", "failure", stats.errored);
-    track("Functions Deploy (Result)", "success", stats.success);
+    track("Functions Deploy (Result)", "failure", errorHandler.errors.length);
+    track("Functions Deploy (Result)", "success", stats.total - errorHandler.errors.length);
   }
   // TODO: Track other stats here - maybe time of full deployment?
 }

Original file line number	Diff line number	Diff line change
`@@ -184,8 +184,8 @@ export function logAndTrackDeployStats(queue: Queue<any, any>, errorHandler: Err`
`184`	`184`	logger.debug(`${errorHandler.errors.length} Functions Errored`);
`185`	`185`	logger.debug(`Average Function Deployment time: ${stats.avg}`);
`186`	`186`	`if (stats.total > 0) {`
`187`		`- track("Functions Deploy (Result)", "failure", stats.errored);`
`188`		`- track("Functions Deploy (Result)", "success", stats.success);`
	`187`	`+ track("Functions Deploy (Result)", "failure", errorHandler.errors.length);`
	`188`	`+ track("Functions Deploy (Result)", "success", stats.total - errorHandler.errors.length);`
`189`	`189`	`}`
`190`	`190`	`// TODO: Track other stats here - maybe time of full deployment?`
`191`	`191`	`}`