Skip to content

Commit 9cc5e13

Browse files
prakhar1989bojeil-google
authored andcommitted
incorporated PR comments
1 parent 0afae0e commit 9cc5e13

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

javascript/widgets/config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ firebaseui.auth.widget.Config.prototype.isDisplayNameRequired = function() {
299299

300300
for (var i = 0; i < signInOptions.length; i++) {
301301
if (signInOptions[i]['provider'] == firebase.auth.EmailAuthProvider.PROVIDER_ID
302-
&& signInOptions[i]['requireDisplayName'] !== undefined) {
302+
&& typeof signInOptions[i]['requireDisplayName'] !== 'undefined') {
303303
return /** @type {boolean} */ (!!signInOptions[i]['requireDisplayName']);
304304
}
305305
}

javascript/widgets/handler/passwordsignup_test.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,7 @@ function testHandlePasswordSignUp_withoutDisplayName() {
108108
testAuth.assertCreateUserWithEmailAndPassword(
109109
[passwordAccount.getEmail(), '123123'], function() {
110110
testAuth.setUser({
111-
'email': passwordAccount.getEmail(),
112-
'displayName': passwordAccount.getDisplayName()
111+
'email': passwordAccount.getEmail()
113112
});
114113
return testAuth.currentUser;
115114
});

0 commit comments

Comments
 (0)