Skip to content

Commit bfc646c

Browse files
committed
Porting over some Github Actions fixes from the v9 PR
1 parent 4d61fc6 commit bfc646c

File tree

3 files changed

+12
-14
lines changed

3 files changed

+12
-14
lines changed

.github/workflows/test.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ name: Test
33
on:
44
push:
55
branches:
6-
- "**"
6+
- master
77
pull_request:
8-
branches:
8+
branches:
99
- "**"
1010

1111
env:
@@ -33,8 +33,11 @@ jobs:
3333
${{ runner.os }}-14-node_modules-
3434
- name: NPM install
3535
if: steps.node_modules_cache.outputs.cache-hit != 'true'
36-
run: npm ci
37-
- name: Build & run tests
36+
# Start sauce connect here, so it's ready to go by the time we need it
3837
run: |
38+
npm ci
3939
./buildtools/sauce_connect.sh &
40-
npm test -- --saucelabs
40+
- name: Build & run tests
41+
run: npm run test
42+
- name: Run tests in Saucelabs
43+
run: ./buildtools/run_tests.sh --saucelabs

buildtools/generate_test_files.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,9 @@
2424
cd "$(dirname $(dirname "$0"))"
2525

2626
echo "Compiling templates..."
27-
npm run build build-soy
27+
npm run build-soy
2828
mkdir -p ./generated
2929
cp -r ./out/soy/* ./generated
30-
npm run build clean
3130

3231
echo "Generating dependency file..."
3332
node $(npm bin)/closure-make-deps \

buildtools/run_tests.sh

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,11 @@ if [[ $1 = "--saucelabs" ]]; then
8080
$PROTRACTOR_BIN_PATH/protractor protractor.conf.js --saucelabs $2
8181
fi
8282
else
83-
# https://github.com/angular/webdriver-manager/issues/404
84-
echo "Updating webdriver-manager dependency."
85-
cd ./node_modules/protractor/
86-
npm i webdriver-manager@latest
87-
cd ../../
8883
echo "Using Headless Chrome."
8984
# Updates Selenium Webdriver.
90-
echo "$PROTRACTOR_BIN_PATH/webdriver-manager update --gecko=false"
91-
$PROTRACTOR_BIN_PATH/webdriver-manager update --gecko=false
85+
GOOGLE_CHROME_VERSION=$(google-chrome --product-version || echo 'latest')
86+
echo "$PROTRACTOR_BIN_PATH/webdriver-manager update --versions.chrome $GOOGLE_CHROME_VERSION --gecko=false"
87+
$PROTRACTOR_BIN_PATH/webdriver-manager update --versions.chrome $GOOGLE_CHROME_VERSION --gecko=false
9288
# Start Selenium Webdriver.
9389
echo "$PROTRACTOR_BIN_PATH/webdriver-manager start &>/dev/null &"
9490
$PROTRACTOR_BIN_PATH/webdriver-manager start &>/dev/null &

0 commit comments

Comments
 (0)