Skip to content

Commit 4af5723

Browse files
Sebastian Rothcollinjackson
Sebastian Roth
authored andcommitted
[firebase_remote_config] Bumps Android Firebase dependency to 19.0.3 (#1443)
* Bump AGP, Gradle & Google Services Plugin * Bumps dependency to Firebase Config 19.0.3 * Replaces a deprecated method usage with the updated version
1 parent 23c8746 commit 4af5723

File tree

6 files changed

+31
-13
lines changed

6 files changed

+31
-13
lines changed

packages/firebase_remote_config/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## 0.3.0
2+
3+
* Update Android Firebase Remote Config dependency to 19.0.3.
4+
* Resolve an Android compiler warning due to deprecated API usage.
5+
* Bump Gradle, AGP & Google Services plugin versions.
6+
17
## 0.2.1
28

39
* Support Android V2 embedding.

packages/firebase_remote_config/android/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ buildscript {
88
}
99

1010
dependencies {
11-
classpath 'com.android.tools.build:gradle:3.3.0'
11+
classpath 'com.android.tools.build:gradle:3.5.2'
1212
}
1313
}
1414

@@ -32,8 +32,8 @@ android {
3232
disable 'InvalidPackage'
3333
}
3434
dependencies {
35-
api 'com.google.firebase:firebase-config:16.4.1'
36-
implementation 'com.google.firebase:firebase-common:16.1.0'
35+
api 'com.google.firebase:firebase-config:19.0.3'
36+
implementation 'com.google.firebase:firebase-common:19.3.0'
3737
implementation 'androidx.annotation:annotation:1.0.0'
3838
}
3939
}

packages/firebase_remote_config/android/src/main/java/io/flutter/plugins/firebase/firebaseremoteconfig/MethodCallHandlerImpl.java

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,23 @@ public void onComplete(Task<Void> task) {
102102
}
103103
case "RemoteConfig#activate":
104104
{
105-
boolean newConfig = FirebaseRemoteConfig.getInstance().activateFetched();
106-
Map<String, Object> properties = new HashMap<>();
107-
properties.put("parameters", getConfigParameters());
108-
properties.put("newConfig", newConfig);
109-
result.success(properties);
105+
FirebaseRemoteConfig.getInstance()
106+
.activate()
107+
.addOnCompleteListener(
108+
new OnCompleteListener<Boolean>() {
109+
@Override
110+
public void onComplete(Task<Boolean> task) {
111+
if (!task.isSuccessful()) {
112+
String errorMessage = "Unable to complete activate.";
113+
result.error("activateFailed", errorMessage, null);
114+
} else {
115+
Map<String, Object> properties = new HashMap<>();
116+
properties.put("parameters", getConfigParameters());
117+
properties.put("newConfig", task.getResult());
118+
result.success(properties);
119+
}
120+
}
121+
});
110122
break;
111123
}
112124
case "RemoteConfig#setDefaults":

packages/firebase_remote_config/example/android/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ buildscript {
55
}
66

77
dependencies {
8-
classpath 'com.android.tools.build:gradle:3.3.0'
9-
classpath 'com.google.gms:google-services:4.3.0'
8+
classpath 'com.android.tools.build:gradle:3.5.2'
9+
classpath 'com.google.gms:google-services:4.3.2'
1010
}
1111
}
1212

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#Fri Jun 23 08:50:38 CEST 2017
1+
#Mon Nov 18 11:38:44 GMT 2019
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.2-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip

packages/firebase_remote_config/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: Flutter plugin for Firebase Remote Config. Update your application
33
re-releasing.
44
author: Flutter Team <[email protected]>
55
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_remote_config
6-
version: 0.2.1
6+
version: 0.3.0
77

88
dependencies:
99
flutter:

0 commit comments

Comments
 (0)