Skip to content

Commit d3954bc

Browse files
committed
fix: key names
1 parent f90e44c commit d3954bc

File tree

8 files changed

+27
-30
lines changed

8 files changed

+27
-30
lines changed

packages/firebase_analytics/firebase_analytics/android/src/main/java/io/flutter/plugins/firebase/analytics/Constants.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
public class Constants {
1010
public static final String AD_STORAGE_CONSENT_GRANTED = "adStorageConsentGranted";
1111
public static final String ANALYTICS_STORAGE_CONSENT_GRANTED = "analyticsStorageConsentGranted";
12-
public static final String AD_PERSONALIZATION_CONSENT_GRANTED = "adPersonalizationConsentGranted";
12+
public static final String AD_PERSONALIZATION_SIGNALS_CONSENT_GRANTED = "adPersonalizationSignalsConsentGranted";
1313
public static final String AD_USER_DATA_CONSENT_GRANTED = "adUserDataConsentGranted";
1414
public static final String USER_ID = "userId";
1515
public static final String EVENT_NAME = "eventName";

packages/firebase_analytics/firebase_analytics/android/src/main/java/io/flutter/plugins/firebase/analytics/FlutterFirebaseAnalyticsPlugin.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -291,8 +291,8 @@ private Task<Void> setConsent(final Map<String, Object> arguments) {
291291
(Boolean) arguments.get(Constants.AD_STORAGE_CONSENT_GRANTED);
292292
final Boolean analyticsStorageGranted =
293293
(Boolean) arguments.get(Constants.ANALYTICS_STORAGE_CONSENT_GRANTED);
294-
final Boolean adPersonalizationGranted =
295-
(Boolean) arguments.get(Constants.AD_PERSONALIZATION_CONSENT_GRANTED);
294+
final Boolean adPersonalizationSignalsGranted =
295+
(Boolean) arguments.get(Constants.AD_PERSONALIZATION_SIGNALS_CONSENT_GRANTED);
296296
final Boolean adUserDataGranted =
297297
(Boolean) arguments.get(Constants.AD_USER_DATA_CONSENT_GRANTED);
298298
HashMap<FirebaseAnalytics.ConsentType, FirebaseAnalytics.ConsentStatus> parameters =
@@ -314,10 +314,10 @@ private Task<Void> setConsent(final Map<String, Object> arguments) {
314314
: FirebaseAnalytics.ConsentStatus.DENIED);
315315
}
316316

317-
if (adPersonalizationGranted != null) {
317+
if (adPersonalizationSignalsGranted != null) {
318318
parameters.put(
319319
FirebaseAnalytics.ConsentType.AD_PERSONALIZATION,
320-
adPersonalizationGranted
320+
adPersonalizationSignalsGranted
321321
? FirebaseAnalytics.ConsentStatus.GRANTED
322322
: FirebaseAnalytics.ConsentStatus.DENIED);
323323
}

packages/firebase_analytics/firebase_analytics/ios/Classes/FLTFirebaseAnalyticsPlugin.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
NSString *const kFLTFirebaseAnalyticsParameters = @"parameters";
1616
NSString *const kFLTFirebaseAnalyticsAdStorageConsentGranted = @"adStorageConsentGranted";
1717
NSString *const kFLTFirebaseAnalyticsStorageConsentGranted = @"analyticsStorageConsentGranted";
18-
NSString *const kFLTFirebaseAdPersonalizationConsentGranted = @"adPersonalizationConsentGranted";
18+
NSString *const kFLTFirebaseAdPersonalizationSignalsConsentGranted = @"adPersonalizationSignalsConsentGranted";
1919
NSString *const kFLTFirebaseAdUserDataConsentGranted = @"adUserDataConsentGranted";
2020
NSString *const kFLTFirebaseAnalyticsUserId = @"userId";
2121

@@ -139,7 +139,7 @@ - (void)resetAnalyticsDataWithMethodCallResult:(FLTFirebaseMethodCallResult *)re
139139
- (void)setConsent:(id)arguments withMethodCallResult:(FLTFirebaseMethodCallResult *)result {
140140
NSNumber *adStorageGranted = arguments[kFLTFirebaseAnalyticsAdStorageConsentGranted];
141141
NSNumber *analyticsStorageGranted = arguments[kFLTFirebaseAnalyticsStorageConsentGranted];
142-
NSNumber *adPersonalizationGranted = arguments[kFLTFirebaseAdPersonalizationConsentGranted];
142+
NSNumber *adPersonalizationSignalsGranted = arguments[kFLTFirebaseAdPersonalizationSignalsConsentGranted];
143143
NSNumber *adUserDataGranted = arguments[kFLTFirebaseAdUserDataConsentGranted];
144144

145145
NSMutableDictionary<FIRConsentType, FIRConsentStatus> *parameters =
@@ -154,9 +154,9 @@ - (void)setConsent:(id)arguments withMethodCallResult:(FLTFirebaseMethodCallResu
154154
[analyticsStorageGranted boolValue] ? FIRConsentStatusGranted : FIRConsentStatusDenied;
155155
}
156156

157-
if (adPersonalizationGranted != nil) {
157+
if (adPersonalizationSignalsGranted != nil) {
158158
parameters[FIRConsentTypeAnalyticsStorage] =
159-
[adPersonalizationGranted boolValue] ? FIRConsentStatusGranted : FIRConsentStatusDenied;
159+
[adPersonalizationSignalsGranted boolValue] ? FIRConsentStatusGranted : FIRConsentStatusDenied;
160160
}
161161

162162
if (adUserDataGranted != nil) {

packages/firebase_analytics/firebase_analytics/lib/src/firebase_analytics.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,14 +137,14 @@ class FirebaseAnalytics extends FirebasePluginPlatform {
137137
Future<void> setConsent({
138138
bool? adStorageConsentGranted,
139139
bool? analyticsStorageConsentGranted,
140-
bool? adPersonalizationGranted,
141-
bool? adUserDataGranted,
140+
bool? adPersonalizationSignalsConsentGranted,
141+
bool? adUserDataConsentGranted,
142142
}) async {
143143
await _delegate.setConsent(
144144
adStorageConsentGranted: adStorageConsentGranted,
145145
analyticsStorageConsentGranted: analyticsStorageConsentGranted,
146-
adPersonalizationGranted: adPersonalizationGranted,
147-
adUserDataGranted: adUserDataGranted,
146+
adPersonalizationSignalsConsentGranted: adPersonalizationSignalsConsentGranted,
147+
adUserDataConsentGranted: adUserDataConsentGranted,
148148
);
149149
}
150150

packages/firebase_analytics/firebase_analytics_platform_interface/lib/src/method_channel/method_channel_firebase_analytics.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ class MethodChannelFirebaseAnalytics extends FirebaseAnalyticsPlatform {
7373
Future<void> setConsent({
7474
bool? adStorageConsentGranted,
7575
bool? analyticsStorageConsentGranted,
76-
bool? adPersonalizationGranted,
77-
bool? adUserDataGranted,
76+
bool? adPersonalizationSignalsConsentGranted,
77+
bool? adUserDataConsentGranted,
7878
}) async {
7979
try {
8080
return channel.invokeMethod<void>(
@@ -84,9 +84,9 @@ class MethodChannelFirebaseAnalytics extends FirebaseAnalyticsPlatform {
8484
'adStorageConsentGranted': adStorageConsentGranted,
8585
if (analyticsStorageConsentGranted != null)
8686
'analyticsStorageConsentGranted': analyticsStorageConsentGranted,
87-
if (adPersonalizationGranted != null)
88-
'adPersonalizationGranted': adPersonalizationGranted,
89-
if (adUserDataGranted != null) 'adUserDataGranted': adUserDataGranted,
87+
if (adPersonalizationSignalsConsentGranted != null)
88+
'adPersonalizationSignalsConsentGranted': adPersonalizationSignalsConsentGranted,
89+
if (adUserDataConsentGranted != null) 'adUserDataConsentGranted': adUserDataConsentGranted,
9090
},
9191
);
9292
} catch (e, s) {

packages/firebase_analytics/firebase_analytics_platform_interface/lib/src/platform_interface/platform_interface_firebase_analytics.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,8 @@ abstract class FirebaseAnalyticsPlatform extends PlatformInterface {
170170
Future<void> setConsent({
171171
bool? adStorageConsentGranted,
172172
bool? analyticsStorageConsentGranted,
173-
bool? adPersonalizationGranted,
174-
bool? adUserDataGranted,
173+
bool? adPersonalizationSignalsConsentGranted,
174+
bool? adUserDataConsentGranted,
175175
}) {
176176
throw UnimplementedError('setConsent() is not implemented');
177177
}

packages/firebase_analytics/firebase_analytics_web/lib/firebase_analytics_web.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ class FirebaseAnalyticsWeb extends FirebaseAnalyticsPlatform {
6767
Future<void> setConsent({
6868
bool? adStorageConsentGranted,
6969
bool? analyticsStorageConsentGranted,
70-
bool? adPersonalizationGranted,
71-
bool? adUserDataGranted,
70+
bool? adPersonalizationSignalsConsentGranted,
71+
bool? adUserDataConsentGranted,
7272
}) async {
7373
throw UnimplementedError('setConsent() is not supported on Web.');
7474
}

packages/firebase_analytics/firebase_analytics_web/test/firebase_analytics_web_test.mocks.dart

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
// Copyright 2024, the Chromium project authors. Please see the AUTHORS file
2-
// for details. All rights reserved. Use of this source code is governed by a
3-
// BSD-style license that can be found in the LICENSE file.
4-
51
// Mocks generated by Mockito 5.4.4 from annotations
62
// in firebase_analytics_web/test/firebase_analytics_web_test.dart.
73
// Do not manually edit this file.
@@ -146,8 +142,8 @@ class MockFirebaseAnalyticsWeb extends _i1.Mock
146142
_i5.Future<void> setConsent({
147143
bool? adStorageConsentGranted,
148144
bool? analyticsStorageConsentGranted,
149-
bool? adPersonalizationGranted,
150-
bool? adUserDataGranted,
145+
bool? adPersonalizationSignalsConsentGranted,
146+
bool? adUserDataConsentGranted,
151147
}) =>
152148
(super.noSuchMethod(
153149
Invocation.method(
@@ -156,8 +152,9 @@ class MockFirebaseAnalyticsWeb extends _i1.Mock
156152
{
157153
#adStorageConsentGranted: adStorageConsentGranted,
158154
#analyticsStorageConsentGranted: analyticsStorageConsentGranted,
159-
#adPersonalizationGranted: adPersonalizationGranted,
160-
#adUserDataGranted: adUserDataGranted,
155+
#adPersonalizationSignalsConsentGranted:
156+
adPersonalizationSignalsConsentGranted,
157+
#adUserDataConsentGranted: adUserDataConsentGranted,
161158
},
162159
),
163160
returnValue: _i5.Future<void>.value(),

0 commit comments

Comments
 (0)